Arduino_core_stm32: [F4] I2C broken since last STM32F4 HAL update

[charlie1024]

_[Edit: transferred from stm32duino/STM32RTC]_

Hello,
I recently seen the board library was updated some days ago and the HAL feature was newly implemented.
I thought that with the new master branch board platform the new library will work, so with my Nucleo-F411RE I tried to operate the new library.

It worked without I2C. I use D14/D15(I2C1) and if I connect any I2C device, then the MCU goes to forever sleep(all codes are stopped).

This code shows:

#include <Wire.h>
#include <STM32RTC.h>
STM32RTC& rtc = STM32RTC::getInstance();

void setup() {
  // put your setup code here, to run once:
  rtc.setClockSource(STM32RTC::LSE_CLOCK);
  rtc.begin(false); // initialize RTC 24H format

  if (!rtc.isTimeSet()) {
    rtc.setTime(0, 0, 0);
    rtc.setDate(1, 1, 19); // fallback
  }
  pinMode(LED_BUILTIN, OUTPUT);

  Wire.begin();

  Wire.beginTransmission(0x50);
  Wire.write(0);
  Wire.endTransmission();
}

void loop() {
  // put your main code here, to run repeatedly:
  delay(500);
  digitalWrite(LED_BUILTIN, !digitalRead(LED_BUILTIN));
}

0x50 means the EEPROM device and I just wrote a waste data to the line, so there must be no problem.
However If I use this code with any I2C device connected, F411RE just halts and not respond for anything(interrupts are all stopped too).

Couldn't be the new library used yet? Or is this a bug?

Thank you.

[charlie1024]

Additionally confirmed that the source caused halt only with Wire library, without STM32RTC and all related codes. It's so confusing. Initially I thought the RTC library has an issue with the master branch board platform but it seems that the core has another problem.

[fpistm]

Hi @charlie1024
Thanks for report.
Could you give me more detail about your setup.
Which core version (master repo? official 1.5.0?..) STM32RTC version (I guess this is the master)? Board exact reference (MBxxxxx)? Arduino IDE version?

[charlie1024]

Hello,
I have MB1136-C-04(It has a 32.768kHz crystal).
Used core was directly got from the master branch. Official 1.5.0 seems doesn't support the new library so It will be out of the problem. STM32RTC version is from the master branch as well.
Finally, I'm using Arduino 1.8.8, which is the latest and before changing the core, the Arduino didn't make any problems.

[fpistm]

Ok thanks. I will test on my side when possible.

[fpistm]

@charlie1024,
I confirm this is a bug in the core since the last HAL update for F4.

[fpistm]

As a workaround you can revert those 2 commits:
https://github.com/stm32duino/Arduino_Core_STM32/commit/df4966143edb3811c7f94fb906193417b9ccd4fb
https://github.com/stm32duino/Arduino_Core_STM32/commit/0e8722f4ffa6e18033f9b061b6c5bd93353e06de

[charlie1024]

I tried to implement new RTC feature with [RTC] Avoid reset time after low power mode #442 and that did work in 1.5.0 release platform. I hope the bug could be resolved. Thank you for assistance.

[fpistm]

Of course this will be resolved ;)
Moreover there is a workaround to not block user who want use the master.

[fpistm]

Issue found and fixed.