Archisteamfarm: Remove arbitrary time constraints on AutoSteamSaleEvent

[DFNCTSC]

Suggestion

Remove arbitrary 1-hour from start and every 8 hour call to AutoSteamSaleEvent

Purpose

Make function more efficient and streamline further issues

Solution

Remove the 1-hour and 8-hour parameters, and set it so it checks immediately before checking badge pages and then every 24-hours after that.

Why currently available solutions are not sufficient?

Because it makes some users wait an hour to run the AutoSteamSaleEvent function if that is their only intention of running ASF at the time of running. For instance, if ASF is started within an hour before the Sale event resets for the next day the user misses those cards. Most users don't have the privilege to run ASF 24/7/365 like you do.

Does your suggestion fall into ASF scope?

Yes, the whole purpose is to get the Steam Sale cards.

Is your suggestion abiding to Steam guidelines?

Yes.

Additional info

I know you're going to probably say "No" because you're stubborn af but just putting this on Github for posterity.

[Abrynos]

Make function more efficient

Efficiency is not determined by the speed at which it MAY work for one single user but at the speed it works for ALL users. removing this delay would cause too many users starting the program as soon as possible after the reset happens and thus:

• DDOSing steam servers
• increasing the probability of steam-server-glitches

Remove the 1-hour and 8-hour parameters, and set it so it checks immediately before checking badge pages and then every 24-hours after that

this would actually be more inefficient as the chance of steam-server-fuckups is pretty high if you only try once. especially if it's within the first part of the day the new items are available as most people try then.

Because it makes some users wait an hour to run the AutoSteamSaleEvent function if that is their only intention of running ASF at the time of running

Getting sale-cards isn't the main purpose of the project. the main purpose is still to farm normal cards. everything else is an extra and should (and will) be done in a way that doesn't DDOS steam servers in favour of valve not banning ASF users on sight. Even if the only purpose of you running ASF is getting those sale cards: it's not for most users. the main goal of the project is still idling cards from normal games you own and that's the goal of most users as well.

if ASF is started within an hour before the Sale event resets for the next day the user misses those cards

if ASF is started within an hour before the sale event resets for the next day ASF will try to get those cards within an hour after the sale event resets for the next day and every 8 hours after that to make sure you got them all even if those requests failed the first time.

Does your suggestion fall into ASF scope?
Yes

No. as i explained above this would cause too many people starting ASF immediately after the event resets (and RE-start ASF if requests fail at some point [which will]). putting such a huge load on steam servers will not only make server-glitches more likely but will also make people working at valve angry which we can't afford as a community.

Most users don't have the privilege to run ASF 24/7/365 like you do.

I'm running it on a Raspberrry Pi 2b+ which cost me ~20€ with a PSU, a case and coolers. Power cost is ~2 or 3€ a year. You don't need a powerful server for this and if you can't afford to run ASF for at least one or two hours a day you got MUCH bigger problems than not getting sale cards in the first place and should not think of those virtual items at all.

[JustArchi]

I know you're going to probably say "No" because you're stubborn af

I say no because I'm stubborn af. For more serious answer, see above.