Archisteamfarm: ProtectedDataForCurrentUser doesn't work

[tambry]

Using the config tool I input my username and password and then select ProtectedDataForCurrentUser as the password format.
After running ASF.exe the following error is displayed:

ASF-75364|ERROR|ASF|DecryptProtectedDataForCurrentUser() System.FormatException: The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.
   at System.Convert.FromBase64_Decode(Char* startInputPtr, Int32 inputLength, Byte* startDestPtr, Int32 destLength)
   at System.Convert.FromBase64CharPtr(Char* inputPtr, Int32 inputLength)
   at System.Convert.FromBase64String(String s)
   at ArchiSteamFarm.CryptoHelper.DecryptProtectedDataForCurrentUser(String encrypted)

Using Windows 10 Pro 64-bit version 14393.576 with .NET Framework 4.6.2 that comes with VS15 RC.

[JustArchi]

Please review the guidelines for contributing to this repository.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md

If my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue, please close my issue immediately - I won't complain.

[tambry]

After browsing through the code, it seems to be due to the password actually never being encrypted when you close the config generator.

[Ryzhehvost]

Y U NO read before you write?
https://github.com/JustArchi/ArchiSteamFarm/wiki/Security

In order to use encrypted password, you should firstly log in to Steam as usual, either with PlainText or None option, then generate encrypted passwords using !password command. Pick the encryption method you like, then put the encrypted password you got as SteamPassword bot config property, and finally don't forget to change PasswordFormat to the one that matches your chosen encryption method.

[tambry]

I wasn't aware of there being a wiki page for that. If I was aware, I would have read it. Might be worth adding links to the relevant wiki pages in the config generator (or improving user friendliness).

From the name itself, you wouldn't expect it to need to be logged into Steam to actually encrypt it. From the looks of it doesn't either, as ProtectedData.Protect is simply used with the password and the static salt. My expectation would've been that the password will be encrypted with the chosen method after closing the config generator, but as it turns out, it doesn't.

Other than that, ASF is better than IdleMaster 👍