Archisteamfarm: Status for succeeded key redemption is NoDetail instead of Success

[pxnt]

Since very recently (idk when it started, possibly after update) every succeeded key redeption gives out the following message:
<bot> Key: key | Status: NoDetail | Items: [123, Game]
The game is in the library afterwards as usual, it's just quite distracting.

Side note: when redeeming more keys than bot count, with all bots set to distribute and such, they will not cycle the leftover keys further after getting from the first to last bot. That makes redeeming with the otherwise good efficiency quite annoying (stacking keys with CTRL+Enter inbetween) as you need to resend all unused keys again and again, so maybe the redemption loop should instead end if the same key went through all bots once, with the result that all bots already have that game.

[pxnt]

Sorry, just realized that that is intended as is.

[Ryzhehvost]

Well, I liked previous status codes better, but if I understend it right - it's not up to ASF, it's just the codes SteamKit2 returns changed.

[JustArchi]

@Ryzhehvost SK2 added reverse-engineered headers from Steam client, and this is how Valve named all statuses. Previously ASF would have barely 9-10 recognized statuses based on my own tests, so they were also named after me. Now ASF switched to "official" types specified by Valve, which isn't only crucial compatibility-wise, but also far more complete, since those headers include over 100 different statuses, while ASF had barely 9-10 previously.

If I change something, I always have a very good reason behind it. I don't like this generic NoDetail either, and I could "patch it up" to return something better, but I intentionally don't want to do this, since ASF should return status as compatible with Valve status as possible, instead of what I think "looks better".

[Ryzhehvost]

Thanks for the explanation! I wasn't aware there are so many different statuses, might want to examine what they got there.

[JustArchi]

Be my guest 👍