Arcade: Need to specify a license

Created on 28 Feb 2018  路  16Comments  路  Source: dotnet/arcade

Uploading a lot of code from difference sources now. What license should we be using here?

Most helpful comment

We have approval from JoC

All 16 comments

Same as we use elsewhere for .NET Core? Some MIT/Apache license, (c) .NET Foundation?

Be sure and include the headers. @terrajobst has the specifics...

License can apply to a few different things.

Repo

There's no license file in the repo at the moment even though most of the headers in files refer to one.

<!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->

Can we just add this license to the repo?

https://github.com/dotnet/roslyn/blob/master/License.txt

Is the above mentioned header correct?

Package

For the package, we currently set the license to what RepoToolset defaults

<PackageLicenseUrl>http://go.microsoft.com/fwlink/?LinkId=529443</PackageLicenseUrl>

For the package license we should point to the license in this repo. See corefx as an example: https://github.com/dotnet/corefx/blob/master/Packaging.props#L17

<LicenseUrl>https://github.com/dotnet/corefx/blob/master/LICENSE.TXT</LicenseUrl>

For the repo license was under impression everything should be MIT (https://github.com/dotnet/corefx/blob/master/LICENSE.TXT) but I think that is a question for @richlander @terrajobst .

@terrajobst @richlander , can you provide guidance?

Current plan is to use the MIT license for this repo and target having that PR merged by EOD tomorrow (3/14). I'm hoping that gives enough time for feedback if there are issues with using the MIT license.

Use MIT. As I said earlier, the bigger question is whether you have director sign-off for the OSS release. I assume the answer to be yes.

@shawnro is getting an ACK

Cool. Just making sure we know who's volunteering to be fired if things go south ;-)

On top of using MIT, make sure to run the formatter to add the copyright/license headers if you haven't done so already. Don't do it manually.

We have approval from JoC

馃ぉ

Which formatter specifically are you referring to?

https://github.com/dotnet/codeformatter which is what we use in the core repos.

I don't think the codeformatter works with Sdk style projects.

https://github.com/dotnet/codeformatter/issues/271

@chcosta is correct. It's broken until the Roslyn workspaces work goes through. Once that's there it will support SDK style projects.

Was this page helpful?
0 / 5 - 0 ratings