Apisix-dashboard: Feat: Rewrite all E2E tests using the Ginkgo

Created on 23 Feb 2021  路  9Comments  路  Source: apache/apisix-dashboard

Feature request

Rewrite all E2E tests using the Ginkgo.

There are a lot of E2E tests that need to be rewritten, so we record the rewriting of E2E in this issue.

E2E test rewrite list (by file name)

  • [ ] skywalking-route_with_trace_plugin_test
  • [ ] authentication_test - @nic-chen
  • [ ] balancer_test - @nic-chen
  • [ ] consumer_test - @nic-chen
  • [ ] global_rule_test - @nic-chen
  • [ ] id_compatible_test - @nic-chen
  • [ ] json_schema_validate_test - @nic-chen
  • [ ] label_test - @nic-chen
  • [ ] route_export_test - @Jaycean
  • [ ] route_import_test - @bisakhmondal
  • [ ] route_service_upstream_test - @Jaycean
  • [ ] route_remote_addr_test - @Jaycean
  • [x] route_test - @nic-chen
  • [x] route_with_management_fileds_test - @bisakhmondal
  • [x] route_with_methods_test - @bisakhmondal
  • [x] route_with_plugin_cors_test - @bisakhmondal
  • [x] route_with_plugin_http_logger_test
  • [ ] route_with_plugin_jwt_test
  • [x] route_with_plugin_limit_count_test - @Jaycean
  • [x] route_with_plugin_orchestration_test - @Jaycean
  • [x] route_with_plugin_prometheus_test - @Jaycean
  • [x] route_with_plugin_proxy_rewrite_test - @Jaycean
  • [x] route_with_priority_test - @Jaycean
  • [x] route_with_script_luacode_test - @Jaycean
  • [x] route_with_uri_uris_test - @Jaycean
  • [x] route_with_valid_remote_addr_test - @Jaycean
  • [x] route_with_vars_test - @Jaycean
  • [x] server_info_test - @Jaycean
  • [x] service_test - @Jaycean
  • [x] ssl_test - @Jaycean
  • [x] upstream_chash_hash_on_test - @Jaycean
  • [x] upstream_chash_query_string_arg_xxx_test - @Jaycean
  • [x] upstream_test - @Jaycean
  • [x] version_test - @Jaycean
  • [x] route_online_debug_test - @Jaycean
good first issue

Most helpful comment

I think we can add the name of the person who is rewriting the file after each todolist, so as to avoid repeated development.

such as

  • [ ] route_ import_ test - @Jaycean

All 9 comments

The PR and issue of the completed E2E can be associated and recorded.

cc @nic-chen @starsz @imjoey

Yeah. Much appreciated.
As far as I know, @nic-chen had finished part of them but hadn't created PR.

Thanks @Jaycean
I think we could list a todo list by module

Thanks @Jaycean
I think we could list a todo list by module

OK, I'll make the list by E2E test file name

I think we can add the name of the person who is rewriting the file after each todolist, so as to avoid repeated development.

such as

  • [ ] route_ import_ test - @Jaycean

Hi @Jaycean, would you mind if I rewrite the route import test in the e2enew test suite :)

Hi @Jaycean, would you mind if I rewrite the route import test in the e2enew test suite :)

Thank you very much. It has been allocated in to do list. You can @ me if you have any questions.

Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following the doc to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you

Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following the doc to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you

Thank you for your contribution. I have replied to you in issue. If you have more questions, you can ask them in issue.

Was this page helpful?
0 / 5 - 0 ratings