Antennapod: Episode titles cut off in playback screen

[keunes]

System info

App version: 2.0.0-RC7

Android version: 7.1.2

Device model: Fairphone 2

Bug description

Expected behaviour:

Display episode title in full in the playback screen: decreasing the episode image size as necessary to create space for multiple text lines.

Current behaviour:

Episode title is cut off (see image)
The issue happens with this super interesting Glitch episode with Payal Arora (about tech like Spotify in non-western worlds).

First occurred: Not sure

[antennapod-bot]

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/tile-name-cut-off-in-portrait-mode/129/3

[tonytamsf]

I will take this, hopefully the fix I did for landscape already will fix this one since I have in increased margins

[ByteHamster]

@tonytamsf actually, I think that your fix (#4292) causes this. It was first shipped in 2.0.0-RC7 and that's when the glitch started to occurr. My guess is that the relative size calculation (convertDpToPixel(newConfig.screenWidthDp) * .80) causes trouble on screens that have aspect ratio 16:9 but it seems to work with 18:9. Setting the height of the cover only based on the screen width probably causes problems. The SquareImageView class has an attribute to use the minimum of available width and height for its size. That should be able to solve the problem.

[tonytamsf]

I will test a fix across more devices

[keunes]

Thanks @tonytamsf :)