Antennapod: Issues with subscriptions view in 1.6 alpha

[keunes]

It's cool to have the Subscriptions view, but there's a few issues that came along with #1826 into the latest alpha:

• numbers are really hard to read with tiles with dark backgrounds (see red circled numbers) _Solved with #1842_
  
  
  
  • proposal: make number color follow theme (almost-black-type-of-gray for the dark theme, white(?) for the light theme)
  
  
• feeds without image don't consistantly show a title (see green ovals) _Solved with #1842_
  
  
  
  • can do some logging if it's needed to figure out what's going on
  
  
• numbers change in a seemingly random fashion (see blue circles) _Solved with #1845_
  
  
  
  • I have selected "number of new and unplayed episodes" in my settings; can't quickly decipher what the random (wrong) number comes from (new, in queue, etc)
  
  
  • again: can do some logging if needed
  
  
• Nav Drawer item/title 'Subscriptions' remains bold if moving from subscriptions to feed view (expected: make the relevant's feed title bold in the Nav Drawer) (see red ovals)
• menu item 'counter' currently is a sub-setting of 'adjust menu'. With the introduction of the Subscriptions setting, this is no longer correct
  
  
  
  • proposal: move it to the menu, change the description (expand to include the subscriptions view)
  
  
• there is no left padding/margin within the tile titles (for 'add podcast' and tiles without image), which makes it a tiny bit hard to read (and just looks bad)
  
  
  
  • proposal: make the left margin/padding the same as the bottom (which I assume is there because of the line height)
  
  

Then, to reiterate remarks made earlier (in https://github.com/AntennaPod/AntennaPod/pull/1826#issuecomment-202167130 and https://github.com/AntennaPod/AntennaPod/pull/1826#issuecomment-202273543):

• the 'Add podcast' tile should be the last item of the list in the subscriptions view
• since it is possible to add subscriptions via the Subscriptions view, which is displayed in the nav drawer by default, 'add podcast' in nav drawer should not be disabled by default
• 'show subscriptions' should be part of the dialog to set the menu items (which can be called via the menu settings screen and long-press on the menu items), rather than having its own item in the menu settings view [hope it's clear what I mean] _Solved with #1846_

App version: 1.6.0.0 (alpha from Google Play)
Android version: 5.1
Devide model: FP2

[TomHennen]

I see the bug with the numbers, I wonder if it's an issue with 6.0. Doesn't happen in the emulator for 4.1.1 or 2.3.7.

I'll investigate the other bugs as well.

I'm not sure I understand how following the theme will help with visibility when the _episodes_ have dark images.

Regarding your other suggestions, we'll see. I'm not sure I agree.

[mfietz]

Maybe it would make sense to distinguish between actual bugs and enhancements...

How about making the counter triangle blue (either AntennaPod blue or the light/dark blue we already have), number just gets primary text color?

Titles: Why not adapt placeholders from queue/episodes and give the textview the same size as the cover? For add feeds, just use Iconify - {fa-plus 300%}\nAdd...

[TomHennen]

This branch addresses some of these concerns: https://github.com/TomHennen/AntennaPod/tree/subscriptions_fixup

• Didn't use iconfiy as @mfietz suggested because it looked ugly (and may have required a different translation). Perhaps he knows how to do it better than me.
• Changed triangle to AP blue
• Not sure why the count is behaving strangely, I couldn't reproduce in an emulator. I did notice some other issues, which I've resolved. I'll need to debug this more.
• If you want 'Add Podcast' removed from the drawer then I think it _must_ come first in Subscriptions view.

I think many of your other suggestions would be better as a different issue.

[mfietz]

Another issue: Adapter assumes fixed positions.
To reproduce: Subscribe to a feed, open subscriptions while the feed is being downloaded and parsed. If done right, you should see duplicate entries.

[keunes]

I wonder if it's an issue with 6.0

You mean Android? I'm on 5.1

how following the theme will help with visibility when the _episodes_ have dark images

"Following the theme" means: number color = 'overlay_dark' or white. These two colors have _bigger contrast (with the triangle background)_ than gray600. (Sure the contrast can also be increased in other ways; just thought it would be nice to do sth with the theme.)

How about making the counter triangle blue, number just gets primary text color?

I'm sorry I only have the chance to comment on it now, but the blue feels odd to me: it looks ok as such on the screenshot, but since it's not used anywhere else it's rather inconsistent with the dark & light themes.

Instead I would do:
background color: use the previously proposed, bit more opaque (e.g. 85%; #D9BFBFBF)
number color: 'overlay_dark' (#2C2C2C) or 'white'

If you want 'Add Podcast' removed from the drawer then I think it _must_ come first in Subscriptions view.

Why is that?
Ease of access: fair point. Then I'd rather have a button in the action bar (like all other apps) than to waste space for such a big plus sign that I hardly ever use. Don't really see how that's bad UX (@mfietz' argument).

Discoverability? Let me illustrate three cases:

• new user, no experience. Opens the app, goes to subscriptions (which should be the first view after fresh install, but that's for another FR), sees the plus sign right at the top.
• experienced podcast listener knows the 'add' tile is in the subscription view because they:
  
  
  
  • added many many feeds over the years and saw the 'add' tile slowly 'moving to the bottom'
  
  
  • saw the plus sign at the top before importing OPML file (& probably remembers that they imported their feeds via the subscriptions view, feels it's a logical place to add stuff from)
  
  

I think many of your other suggestions would be better as a different issue.

As in 'all in one issue' or 'every single one of them in a separate issue'?

[TomHennen]

Issue with the TriangleLabelView is that they're not invalidating and requesting a new layout when content changes. See https://github.com/shts/TriangleLabelView/pull/2

[ByteHamster]

Opening the downloads fragment and afterwards the subscriptions fragment creates a non-functional options menu entry

[TomHennen]

@ByteHamster so it does. Thanks for reporting, but could we please have one 'issue' per request or problem? It makes it much easier to know when we're done. This issue is rather difficult to track.

[keunes]

All issues have been solved / become irrelevant (except one that I addressed in a seperate issue) -> closing