Angularfire: Feature request - Make angularfire2 compatible with Typescript 2.9.2 or later

Created on 19 Sep 2018  路  11Comments  路  Source: angular/angularfire

Version info

Angular: 6.1.7

Firebase: 4.2.1

AngularFire: 5.0.0-rc.11

* Node:* 9.5.0

* OS*: Windows 10

* Screenshots *

Expected behavior

Changing my package.json file to angularefire2 to 5.0.0 version and doing npm install, whereas my Typescript version is 2.9.2, shows a warning that no package was installed because angularfire2 is ok with
typescript >= 2.7.2 & < 2.8.0.

Actual behavior

I have an app that runs with Typescript 2.9.2 and angularfire 5.0.0-rc.11 and that works fine. I installed first angularfire2, then upgraded my typescript version. The app is ok. The problem is when I try to upgrade to version 5.0.0.

Most helpful comment

Angular v7 RC.0 stepped up to TypeScript 3.1.1. It would be nice to support that in this library so that users of @angular/fire can test the Angular RCs.

It would also be nice to release a version that supported the Angular v7 RCs. Currently only ^6.0.0 is supported in 5.0.2.

All 11 comments

I'll take a peek, but for right now we're only committed to keeping it inline with Angular.

Thanks @jamesdaniels, but isn't Angular compatible right now with typescript 3 ?

See
https://github.com/angular/angular/blob/7f1cace2a204aa2e47f9441eb8745a500bdc505a/package.json#L128

Am i misunderstanding something ?

@johanchouquet I believe the angular master branch is ahead of the releases. I don't think angular currently supports typescript 3, nor will it until angular 7.

@thefliik , maybe. But again, I still have my Angular 6.1.x application running with typescript 2.9.2 without any problem with angularfire2 (v5.0.0-rc.11).

And for Angular CLI, it'll run v7 with support for typescript 3.1 at the very least:
Angular CLI v7

I should be able to upgrade to v5 final & latests, not just because of my typescript version.

@johanchouquet Angular CLI v7 also is not released. As of this posting, they recently released v7 rc0. Angular CLI's major versions are released in lock step with Angular's major verson's (same goes for Angular material's major versions). So none of the official, stable releases support typescript 3 (so far as I know). I also run angular 6.x with typescript 2.9.2, but I'm actually not sure if 6.x officially supports typescript 2.9 even. I think the latest currently supported typescript is 2.7.x (I see a console warning when I install Angular 6.x in a project using typescript > 2.7). Typescript 2.9.x seems to work anyway though (I haven't had any problems).

I'd like to upgrade to typescript 3, so I've been trying to keep an eye on the angular releases to see if they added support. Haven't seen anything yet though.

Angular v7 RC.0 stepped up to TypeScript 3.1.1. It would be nice to support that in this library so that users of @angular/fire can test the Angular RCs.

It would also be nice to release a version that supported the Angular v7 RCs. Currently only ^6.0.0 is supported in 5.0.2.

@thefliik , i just updated to latest angular-cli (v6.2.4), and tried ng new project, it ended up creating a new project with this is my devDependencies: "typescript": "~2.9.2". So I'm not talking specially about v3 of typescript, but the fact that I can't update this library to v5.0.x & more, using with latest stable version of Angular (in v6), not v7 (beta / rcs), and so, only because of my typescript version. So far, i could update angularfire2 library without this kind of issue.

Btw @Splaktar , i agree with you. it'd be nice to be able to test angular 7 (rc & more).

Note that the current 5.0.2 release does seem to work with Angular 7.0.0-rc.1. It gives peer dependency warnings but the app still builds and runs.

Typescript 3.1.3 seems to be working without any changes, see #1922

Great! I'll give this a try anytime soon ! Thanks for this update @jamesdaniels .

Was this page helpful?
0 / 5 - 0 ratings

Related issues

adriandurran picture adriandurran  路  3Comments

Leanvitale picture Leanvitale  路  3Comments

itisparas picture itisparas  路  3Comments

KLiFF2606 picture KLiFF2606  路  3Comments

Sun3 picture Sun3  路  3Comments