Angularfire: Adopt NgModule

Created on 13 Jul 2016  路  3Comments  路  Source: angular/angularfire

Provide a FirebaseModule to be referred to by standard AppModules.

  • [ ] Move FIREBASE_PROVIDERS into the FirebaseModule.

See this gist:
https://gist.github.com/StephenFluin/672b85faef772b8102457f4fe5dd02ce

cc: @wardbell @IgorMinar

providers feature
Source
picture StephenFluin
👍1

Most helpful comment

TODOs

  • [ ] Get rid of typings in favor of @types
  • [ ] Get rid of firebase3.d.ts (assuming version published to @types is good)
  • [ ] Add new TS module with NgModule (don't include module in angularfire2.ts yet)
  • [ ] Create a configuration interface for the NgModule that merges defaultFirebase and firebaseAuthConfig configuration objects.
picture jeffbcross on 27 Jul 2016
👍4

All 3 comments

Note that this is blocked by Angular RC.5

jeffbcross picture jeffbcross on 13 Jul 2016
👍1

And in hindsight it should probably be AngularFireModule, not FirebaseModule.

StephenFluin picture StephenFluin on 13 Jul 2016
👍1

TODOs

  • [ ] Get rid of typings in favor of @types
  • [ ] Get rid of firebase3.d.ts (assuming version published to @types is good)
  • [ ] Add new TS module with NgModule (don't include module in angularfire2.ts yet)
  • [ ] Create a configuration interface for the NgModule that merges defaultFirebase and firebaseAuthConfig configuration objects.
jeffbcross picture jeffbcross on 27 Jul 2016
👍4
Was this page helpful?
0 / 5 - 0 ratings

Related issues

isylhdin picture isylhdin  路  3Comments
avanderbergh picture avanderbergh  路  3Comments
harrylincoln picture harrylincoln  路  3Comments
KLiFF2606 picture KLiFF2606  路  3Comments
mypark picture mypark  路  3Comments