Android: Auto picture upload is failing after updating to 1.5.11-beta1

[NickDiMucci]

As of version 1.5.11-beta1, the auto picture upload has been failing to work. See the following log snippet.

Android version 9

ErrorCode: 58JJ:8L9V
E   20210118103858.366  AutoUploadService   Auto upload failed, unable to get images from file store
k.a.c.l.g: java.lang.ClassNotFoundException: org.cryptomator.presentation.e.c
    at org.cryptomator.presentation.l.t.o(Unknown Source:145)
    at org.cryptomator.presentation.l.t.n(Unknown Source:9)
    at org.cryptomator.presentation.service.AutoUploadService.s(Unknown Source:5)
    at org.cryptomator.presentation.service.AutoUploadService.onStartCommand(Unknown Source:34)
    at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3830)
    at android.app.ActivityThread.access$1600(ActivityThread.java:208)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1728)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:205)
    at android.app.ActivityThread.main(ActivityThread.java:6991)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:884)
Caused by: java.lang.ClassNotFoundException: org.cryptomator.presentation.e.c
    at java.lang.Class.classForName(Native Method)
    at java.lang.Class.forName(Class.java:453)
    at java.io.ObjectInputStream.resolveClass(ObjectInputStream.java:628)
    at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1615)
    at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1520)
    at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1776)
    at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
    at java.io.ObjectInputStream.readObject(ObjectInputStream.java:373)
    at org.cryptomator.presentation.l.t.o(Unknown Source:31)
    ... 12 more
Caused by: java.lang.ClassNotFoundException: Didn't find class "org.cryptomator.presentation.e.c" on path: DexPathList[[zip file "/system/framework/org.apache.http.legacy.boot.jar", zip file "/data/app/org.cryptomator-fuMQU4xb-e7Ku5Nug4gL_g==/base.apk"],nativeLibraryDirectories=[/data/app/org.cryptomator-fuMQU4xb-e7Ku5Nug4gL_g==/lib/arm64, /system/lib64, /product/lib64]]
    at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:134)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
    ... 21 more

[NickDiMucci]

I did a full uninstall and reinstall and it fixed the issue for me.

[SailReal]

Thanks for reporting this issue. I can reproduce it and we will take a close look into it.

Next time please use the bug report template.

[SailReal]

~Hmm I've to admit that I'm no longer able to reproduce this problem while updating from 1.5.10 to 1.5.11-beta1 :thinking:.~

~I'm quiet sure that I saw this exception once but I don't know what I can still do to trigger it :confused:.~

Can reproduce it again^^

[SailReal]

The problem occurs in those few lines: FileUtil.kt#L180-L183

The problem is proguard obfuscated the AutoUploadFilesStore.kt in version 1.5.10 to org.cryptomator.presentation.e.c and in version 1.5.11-beta1 to org.cryptomator.presentation.i.a. Object deserialization only works, if among other things the name of the class didn't change.

The main problem is that this file gets obfuscated at all which is easy fixable but to recover the paths from this file is tricky :thinking: .

[SailReal]

Oh wow, what a headache but with https://github.com/cryptomator/android/commit/5f428b59639cb69441c42b73ab3c828a613d1f46 the problem is solved.

Thanks again for reporting!