Android-components: Sync Tabs: Rename RemoteTabsFeature to SyncTabsFeature

Created on 10 Dec 2019 · 6Comments · Source: mozilla-mobile/android-components

"Remote" was an internal component name and probably shouldn't change the feature name.

Things to change:

RemoteTabsFeature -> SyncedTabsFeature.
RemoteTabsStorageSuggestionProvider -> SyncedTabsStorageSuggestionProvider.
mozilla.components.feature.remotetabs -> mozilla.components.feature.syncedtabs.
Component README.
Project README.

<sync-tabs> good first issue ⌨️ code

Source

jonalmeida

All 6 comments

This has potential for a good first bug, but will wait for comment from @eoger to see how they feel about this.

jonalmeida on 10 Dec 2019

Minus nit would be synced versus sync, but yeah I'm ok with the rename!

eoger on 10 Dec 2019

👍1

I can do this.

espertus on 19 Dec 2019

👍1

@eoger @jonalmeida Should I also change mozilla.appservices.remotetabs.RemoteTab and mozilla.components.browser.storage.sync.RemoteTabsStorage?

espertus on 19 Dec 2019

The mozilla.appservices.remotetabs namespace lives in the app services project, and the RemoteTabsStorage is the entry point for that dependency into the a-c FxaAccounts which is the naming convention that's followed there, so let's leave those as is. SyncTabs is the feature that it supports, which was my internal reasoning for renaming the feature (which I forgot to document). 🙂

jonalmeida on 19 Dec 2019

This issue can be closed since https://github.com/mozilla-mobile/android-components/commit/1ff8b84ec75d5dce4b46a5546477ca73d0395776