Android-components: Hold to select in browser-menu

Created on 27 Jun 2019  Â·  9Comments  Â·  Source: mozilla-mobile/android-components

Originally filed by @Nxt3 in mozilla-mobile/fenix#3713:

Why/User Benefit/User Problem

In Google Chrome (and other Android apps), when there is an overflow menu button, you can long press on the menu icon, and then drag down to the menu item you want to select.

In both Firefox apps, you have to tap the menu button and then tap the menu item you want.

What/Requirements

I believe it's because Firefox uses a custom implementation of the overflow menu. I'd love to see this follow how other Android apps work.

Acceptance Criteria (how do I know when I’m done?)

When the overflow menu behaves like other Android apps.

<menu> 🌟 feature

Most helpful comment

@NotWoods Dang man that was quick! Already got a PR open and everything. Props!

All 9 comments

I may have duped this here: https://github.com/mozilla-mobile/fenix/issues/3720

Please close that if so.

@NotWoods Dang man that was quick! Already got a PR open and everything. Props!

Aww. Now I feel bad for @dragocubed who filed an issue on the ref browser in Jan

For what it's worth I didn't even work at Mozilla in January ¯\_(ツ)_/¯

This one will still take some time!

What does r-b mean?

reference browser.

@NotWoods And modest!

Where I work it takes a while for defects to make the whole cycle lol. Wish we could do defects like this.

Best of luck to ya with the new gig. 😎

Dang. Almost two years since the OG issue. Any updates on this?

Was this page helpful?
0 / 5 - 0 ratings