Android-components: Enable kotlin warningsAsErrors on remaining modules that its disabled on

[mcomella]

In #54, I enabled kotlin warnings as errors on modules that already had no errors. For each disabled module, we should:

• Fix the warnings
• Remove it from the list of modules with warnings as errors disabled

When we empty the list, don't forget to enable the check to selectively enable warnings as errors.

[mcomella]

To fix a module locally, you should remove it from the list of suppressed modules in KotlinCompiler.kt, compile kotlin for the production code, the unit test code, and the android test code, e.g. for all modules:

./gradlew compileDebugKotlin compileDebugUnitTest compileDebugAndroidTest

Then fix all the errors.

[mcomella]

@pocmo fwiw, as a downstream consumer, I'd prefer this to happen sooner than later: there are issues the compiler can catch _right now_, before they have a chance to crash our app in production – it'd be great to enforce this at least on the most popular modules like browser-session and browser-engine-*.

[pocmo]

Landed fixes for:

• browser-session
• concept-engine
• browser-engine-gecko-nightly

[Amejia481]

@pocmo Is there a way to pull this list from .buildconfig.yml?

[pocmo]

@Amejia481 Yeah, would be an option. But I don't think it's worth changing the code to a configuration flag in .buildconfig.yml since the goal is for this list to no longer exist. :)

[mcomella]

Landed fixes for:

🙌 Thanks for working on this so quickly! :)

[pocmo]

Additionally off the list now:

• browser-engine-gecko-beta (Thanks merge day!)
• support-base
• support-ktx
• lib-crash

[dector]

Taken:

browser-engine-gecko
browser-engine-servo
browser-menu
browser-errorpages
browser-search
browser-toolbar
concept-toolbar
feature-accounts
feature-awesomebar
feature-contextmenu
feature-customtabs
feature-downloads
feature-intent
feature-prompts
feature-search
feature-session
feature-tabs
feature-toolbar
lib-fetch-okhttp
lib-jexl
samples-toolbar
service-experiments
service-fretboard
service-firefox-accounts
service-glean
support-test
support-utils
tooling-lint
ui-autocomplete
ui-progress
ui-tabcounter

[dector]

Fixes for all modules are on review. :)

[pocmo]

This is finally done. Thank you for all your hard work @dector! 💯