Android-components: Better handling of ACTION_DOWN in NestedGeckoView

Created on 16 Nov 2020  路  5Comments  路  Source: mozilla-mobile/android-components

Investigating https://github.com/mozilla-mobile/fenix/issues/14527 on samples-browserI saw that issue being introduced in aee2029e.

Knowing that GV does it's panning based on the ACTION_DOWN MotionEvent apps send it seems like we are not handling this properly in NestedGeckoView.

Comparing our code with the one from GV where this issue does not reproduce it seems like using a callback system instead of awaiting for a coroutine to complete would fix this (also after testing it).

<engine-gecko>
Source
picture Mugurell

Most helpful comment

Based on user reports this did indeed fix the issue seen on Fenix 馃コ.

picture Mugurell on 18 Nov 2020
👍2

All 5 comments

Closing as PR landed and preparing a release. Please re-open in case there's more to do :).

csadilek picture csadilek on 17 Nov 2020
👍1

Based on user reports this did indeed fix the issue seen on Fenix 馃コ.

Mugurell picture Mugurell on 18 Nov 2020
👍2

Is a fix included in 83.1.0/Nov 18 on Android? I checked the changelogs and tried to tie something to the Bugzilla reports but have been unable to do so.

silvaran picture silvaran on 20 Nov 2020

No, it's not included in Firefox 83.1.0 but in Firefox 84 Beta and Firefox Nightly.

cadeyrn picture cadeyrn on 20 Nov 2020

@cadeyrn Thank you for the quick response!

silvaran picture silvaran on 20 Nov 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

csadilek picture csadilek  路  3Comments
dnarcese picture dnarcese  路  3Comments
cpeterso picture cpeterso  路  6Comments
jonalmeida picture jonalmeida  路  4Comments
csadilek picture csadilek  路  3Comments