Amphtml: <amp-web-push> issue going from "Block" to "Allow" push permission

[rgomezp]

What's the issue?

There is currently a bug (perhaps a limitation) where manually going from "Block" to "Allow" will not correctly reflect the updated push permission on the main page. This leads to issues such as custom prompting widgets not dismissing or simply continuing to appear altogether despite the permission already set to "Allow"

How do we reproduce the issue?

Demo Site

1. Get prompted for push and accept inside the pop up window
2. Manually change the permission in the browser to "Block"
3. Reload the page
4. Manually change the permission in the browser to "Allow"
5. Reload the page
6. See that the main site still thinks notifications are blocked

To fix it in its current state:

1. Visit amp-web-push-permission-dialog.html
2. Refresh the demo page
3. See that it no longer thinks its blocked
4. You still have to re-subscribe by clicking the button

What browsers are affected?

Chrome.

Firefox doesn't work at all do to the new user-gesture requirement causing the programmatic native permission request from failing and flickering the popup before it gets dismissed. (This is another issue altogether)

Which AMP version is affected?

I suspect this has always been broken.

[rgomezp]

@dvoytenko any insights here?

[Ichigo3d]

I checked it on Chrome MAcOS and issue's reproducible.

[dvoytenko]

/to @kristoferbaxter for triage.

[HelaGone]

Hello there! is there any advance on this topic?

[rgomezp]

Hello, just checking if there is any progress?

[nainar]

@kevinkimball could you take a look at this please?

[kevinkimball]

I can confirm that this is the behavior. Checking in the comments for the code, it appears that the permission state is stored in state to avoid having to open a popup to the canonical URL every time when the page is being served from the cache. Here is the relevant comment. Open to suggestions but appears this is the intended behavior, and document authors can customize or omit the blocked state for the push widget.

[rgomezp]

@kevinkimball ,
Thanks for the response. @jkasten2 is there anything you can add?