Amphtml: AMP extension generator (gulp make-extension) is out of date

Created on 8 Jun 2018  路  3Comments  路  Source: ampproject/amphtml

I found that the validation files and some other defaults provided by the AMP extension generator fail to build/behave correctly. We've updated our validator files and patterns for example, and the information in the extension generator is no longer correct.

/to @erwinmombay as owner and for priority triage
/cc @mrjoro for visibility on documentation/cleanup effort

https://github.com/ampproject/amphtml/blob/f06e2b6887294fe8afa9dfd3e88fffe7e8ea1978/build-system/tasks/extension-generator/index.js#L50-L58

Soon Bug caching infra

All 3 comments

To see what we're advocating now for validation see contributing validation rules.

We tried to simplify the necessary code. Now we have an extension_spec that encapsulates what most extensions need.

This issue hasn't been updated in awhile. @erwinmombay Do you have any updates?

Was this page helpful?
0 / 5 - 0 ratings