Amphtml: amp-selector[multiple] should display cursor: pointer on selectable options

Created on 11 May 2020  路  8Comments  路  Source: ampproject/amphtml

In multiselect, cursor:pointer should be on. Or more generically, if we have a meaningful action attached to the click (e.g. unselect for multiselect items), cursor should be pointer.

Related comment thread
Caveat: Unless item is disabled

Layout & CSS amp-selector When Possible Bug components good first issue

Most helpful comment

yeah sure @AtharvaSune can work on it, I am also new here and i am already working on another issue of this repository, so no problem

All 8 comments

Hello. I am new and would love to contribute.
I would like to fix this issue, if no one is already on it.

Sure thing, thanks for your contribution!

Hi, I am new here. If the issue is not already assigned I would like to work on it

@THE-VR7 Let us know if you are still planning to contribute. Otherwise it sounds like @AtharvaSune will be happy to take this on. :) No rush either way.

yeah sure @AtharvaSune can work on it, I am also new here and i am already working on another issue of this repository, so no problem

hey @caroqliu , from what i understood from the linked thread in the description, i need to make some changes in the extensions/amp-selector/0.1/amp-selector.css file so that amp-selector[multiple] displays pointer, right ?

@AtharvaSune Yes that's right :)

Hey @caroqliu just submitted the pr, could you have a look at it , :sweat_smile: if any further changes are required do tell

Was this page helpful?
0 / 5 - 0 ratings

Related issues

akshaylive picture akshaylive  路  3Comments

aghassemi picture aghassemi  路  3Comments

mkhatib picture mkhatib  路  3Comments

torch2424 picture torch2424  路  3Comments

samanthamorco picture samanthamorco  路  3Comments