Amphtml: amp-story boilerplate is invalid

[newmuis]

The boilerplate code for amp-story doesn't validate. We should update this and fix the errors pointed out by the validator.

[newmuis]

/cc @CrystalOnScript

[petekip]

@newmuis Can you assign me this problem?

[newmuis]

@petekip done!

[newmuis]

@petekip are you still interested in working on this?

[petekip]

Yes @newmuis I am on it, thanks

[petekip]

@newmuis I have pushed the updates on my fork! Boilerplate now validates properly

[petekip]

The boilerplate code for amp-story doesn't validate. We should update this and fix the errors pointed out by the validator.

Hi @newmuis , did you get a chance to confirm the fix?

[newmuis]

Hey @petekip, can you create a pull request to pull the changes from your fork into the main amphtml repository?

[petekip]

@newmuis I have created the pull request.

[newmuis]

@petekip can you provide a link to the pull request here? I am unable to find it.

[petekip]

@newmuis here you go: https://github.com/newmuis/amphtml/pull/1/commits/347afef1dbd920ecbdb25205211261b337313689

https://github.com/newmuis/amphtml/pull/1

[newmuis]

Hi @petekip

The commit itself looks pretty good, with maybe some whitespace adjustments to make.

For the pull request, can you instead make a pull request to the ampproject/amphtml repository? Please also make sure that the only commits from the pull request are your own, and that other changes aren't being pulled in mistakenly

[petekip]

Hi @newmuis ,
I see, I have done as you advised. Kindly check https://github.com/ampproject/amphtml/pull/23940

[petekip]

Hi @newmuis I hope you are well, we should close this issue, can you help revert so I can make necessary ammends

[nainar]

Fixed by #23940