Amphtml: amp-ima-video: Does not show Play/Pause buttons when an ad is playing

Created on 21 Jun 2019  路  4Comments  路  Source: ampproject/amphtml

Currently, amp-ima-video does not show the play/pause buttons while an ad is playing.

Demo

Screen Shot 2019-06-20 at 5 08 20 PM

cc @curseagain 馃槃

amp-ima-video Soon Bug monetization

Most helpful comment

@torch2424 I have a fix in progress now, but it requires some tweaks to the logic surrounding play/pause. That logic was written with the assumption that no play button would be displayed until the video started.

Just wanted to give you a heads up! I should have this ready for review soon!

All 4 comments

Oh no! I'll take a look this weekend 馃憤 Thanks for the cc, @torch2424.

@curseagain No worries! More of an FYI than an assignment 馃槃 So no pressure to do this, but if you can / want to that would be rad! 馃憤

@torch2424 I have a fix in progress now, but it requires some tweaks to the logic surrounding play/pause. That logic was written with the assumption that no play button would be displayed until the video started.

Just wanted to give you a heads up! I should have this ready for review soon!

@curseagain Awesome! Thank you very much! Stoked to do a review for this 馃槃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

choumx picture choumx  路  3Comments

radiovisual picture radiovisual  路  3Comments

mrjoro picture mrjoro  路  3Comments

sryze picture sryze  路  3Comments

westonruter picture westonruter  路  3Comments