Amphtml: amp-ima-video: Does not show Play/Pause buttons when an ad is playing
All 4 comments
Oh no! I'll take a look this weekend 馃憤 Thanks for the cc, @torch2424.
curseagain
on 21 Jun 2019
@curseagain No worries! More of an FYI than an assignment 馃槃 So no pressure to do this, but if you can / want to that would be rad! 馃憤
torch2424
on 22 Jun 2019
@torch2424 I have a fix in progress now, but it requires some tweaks to the logic surrounding play/pause. That logic was written with the assumption that no play button would be displayed until the video started.
Just wanted to give you a heads up! I should have this ready for review soon!
curseagain
on 24 Jun 2019
🚀1
🎉1
😄1
👍1
@curseagain Awesome! Thank you very much! Stoked to do a review for this 馃槃
torch2424
on 24 Jun 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
choumx
路
3Comments
radiovisual
路
3Comments
mrjoro
路
3Comments
sryze
路
3Comments
westonruter
路
3Comments
Most helpful comment
@torch2424 I have a fix in progress now, but it requires some tweaks to the logic surrounding play/pause. That logic was written with the assumption that no play button would be displayed until the video started.
Just wanted to give you a heads up! I should have this ready for review soon!