Amphtml: 馃尭 Cherry pick request for #20548 into 1901242049580 (Approved)

Created on 30 Jan 2019  路  5Comments  路  Source: ampproject/amphtml

GitHub issue your cherry pick is fixing:

Issue #20548

PR that you are requesting a cherry pick for:

PR #20588

Release(s) you requesting this cherry pick into:

Production Release? YES

Release Issue #20470

Canary release? YES

Release Issue #20587

Why does this issue meet the cherry pick criteria?

All AMP Pages using AMP Consent with an amp-iframe are currently broken. As their amp-iframe is never laid out. Due to an error in which the parent container is shown and the iframe is shown.

/cc @cramforce
/cc @zhouyx
/cc @Enriqe

Most helpful comment

Thank you all!!

It works perfectly!

All 5 comments

Approved

@torch2424 @zhouyx this cherry pick is ready to test in opt-in dev-channel version 1901302225410.

Can you please verify that the issue is gone there?

cc @Enriqe

Confirmed this to be working in the dev channel per the examples provided in: #20548

screen shot 2019-01-31 at 11 03 00 am
screen shot 2019-01-31 at 11 03 15 am

This is included in release https://github.com/ampproject/amphtml/releases/tag/1901302225410 which was pushed to production today.

Thank you all!!

It works perfectly!

Was this page helpful?
0 / 5 - 0 ratings