Amphtml: when open side bar, click in menu item to scroll to an element and them close side bar the page scroll up

[mauricionr]

What's the issue?

when open side bar, click in menu item to scroll to an element and them close side bar the page scroll up

How do we reproduce the issue?

here Demo

1. Open side bar
2. go to language
3. close side bar
   

   What browsers are affected?

i guess all

Which AMP version is affected?

i guess all versions

[mauricionr]

with this approach i got a different behavior, but master has another behavior

[jridgewell]

@aghassemi here's another history popstate issue with sidebar.

[aghassemi]

changing to p1, this bug totally defeats the whole point of page nav links in sidebar all together.

[aghassemi]

@camelburrito @torch2424 do either of you guys have cycles to fix this bug? (Essentially sidebar scrolls the main page back to top when closed)

[camelburrito]

This is something that MK attempted to fix (I thought he fixed it). I don't think we will have cycles looking into it.

[aghassemi]

@mauricionr Looks like links in sidebar have some special logic for handling in-page navigation which requires presence of href="#id" on a tags. If you add href in addition to the smooth-scroll action call, that should fix your issue. (it has the side benefit of properly updating the Url as well). See https://output.jsbin.com/jolebur for a sample.

Let me know if you still have concerns with this issue.

[torch2424]

Currently working on improving this in the documentation, to make things more clear.

[mauricionr]

Ok :smile:

but i must put the href?

Nicee @torch2424 :tada:

may i close or keep open this issue?

[mauricionr]

thanks @aghassemi

[aghassemi]

np. closing the issue