Amp-wp: CLI integration shows internal methods as commands

Created on 27 Aug 2019  路  2Comments  路  Source: ampproject/amp-wp

When I did work on refactoring the CLI commands, one of the initial steps was to make all internal methods private, so that the commands could act as command classes on their own.

Later, I noticed that the tests were built in such a way to require all internals to be public. So instead of rewriting all the tests, I opened another issue to introduce an abstraction layer (#3077) to remed this problem and come back to later. To make the tests pass for the build, I made the internals public again.

However, now, because of the changed command structure, all of the internal methods are exposed as subcommands because of this:
Image 2019-08-27 at 5 24 39 PM

Bug WP-CLI

Most helpful comment

This should be solved before the next release OR #3079 should not be included in that release.

All 2 comments

This should be solved before the next release OR #3079 should not be included in that release.

Thanks, I'll plan on code reviewing #3229 right away, and moving it to 'Ready For Merging' if/when it passes.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

swissspidy picture swissspidy  路  4Comments

miina picture miina  路  4Comments

westonruter picture westonruter  路  5Comments

miina picture miina  路  5Comments

ernee picture ernee  路  4Comments