Amp-wp: amp soundcloud playlist

Created on 1 Jul 2019  路  5Comments  路  Source: ampproject/amp-wp

soundcloud playlist oembed doesn't work
steps to reproduce:

  1. create new post
  2. add for example following psot content(i'm using text mode in classic editor):
soundcloud playlist embed with shortcode 
[embed]https://soundcloud.com/classical-music-playlist/sets/classical-music-essential-collection[/embed]
soundcloud playlist embed without shortcode
https://soundcloud.com/classical-music-playlist/sets/classical-music-essential-collection
soundcloud playlist amp component
<amp-soundcloud height="657" layout="fixed-height" data-playlistid="40936190" data-color="ff5500"></amp-soundcloud>
  1. visit post ;)
Bug Support

Most helpful comment

@westonruter Thanks a lot for quick fix.
I've tested amp.zip attached to that PR it works perfectly.

All 5 comments

I'm seeing the same thing. Only directly adding the amp-soundcloud is being rendered properly. They both fail with:

<a href="" class="amp-wp-embed-fallback"></a>

The post_content I'm testing with:

<!-- wp:paragraph -->
<p>Embed shortcode:</p>
<!-- /wp:paragraph -->

<!-- wp:shortcode -->
[embed]https://soundcloud.com/classical-music-playlist/sets/classical-music-essential-collection[/embed]
<!-- /wp:shortcode -->

<!-- wp:paragraph -->
<p>Embed block:</p>
<!-- /wp:paragraph -->

<!-- wp:core-embed/soundcloud {"url":"https://soundcloud.com/classical-music-playlist/sets/classical-music-essential-collection","type":"rich","providerNameSlug":"soundcloud","className":"wp-embed-aspect-4-3 wp-has-aspect-ratio"} -->
<figure class="wp-block-embed-soundcloud wp-block-embed is-type-rich is-provider-soundcloud wp-embed-aspect-4-3 wp-has-aspect-ratio"><div class="wp-block-embed__wrapper">
https://soundcloud.com/classical-music-playlist/sets/classical-music-essential-collection
</div></figure>
<!-- /wp:core-embed/soundcloud -->

<!-- wp:paragraph -->
<p>Custom HTML block:</p>
<!-- /wp:paragraph -->

<!-- wp:html -->
<amp-soundcloud height="657" layout="fixed-height" data-playlistid="40936190" data-color="ff5500"></amp-soundcloud>
<!-- /wp:html -->

Thanks for reproducing so quickly @westonruter. Do you by chance know when v1.2.1 is scheduled for?

@maciejmackowiak Please test: https://github.com/ampproject/amp-wp/pull/2722

There is an amp.zip attached to that PR which you can install to test.

@archon810 Probably in the next two weeks. But there is a build you can use right away above.

@westonruter Thanks a lot for quick fix.
I've tested amp.zip attached to that PR it works perfectly.

Awesome, thanks for testing!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

swissspidy picture swissspidy  路  3Comments

fumikito picture fumikito  路  5Comments

westonruter picture westonruter  路  5Comments

luizeof picture luizeof  路  4Comments

alexhaller picture alexhaller  路  5Comments