Amp-wp: Allow reordering of pages by dragging the carousel indicators

Created on 6 Jun 2019  路  12Comments  路  Source: ampproject/amp-wp

Underneath the pages there are little bars for every page in the story.

For faster creation of stories it could be useful to be able to quickly reorder pages by dragging around these editor carousel indicators.

Demo

Changelog entry

  • Added support for reordering pages by dragging carousel indicators
AMP Stories (obsolete) Enhancement

All 12 comments

For reference, #2910 was a previous attempt at this.

Starting looking into this.

Any thoughts on if / how to make it more understandable where to is the reordered page being moved? E.g. perhaps displaying small Page numbers on each indicator while dragging is happening?

reordering-carousel

cc @cathibosco @swissspidy

You mean showing the page numbers below _all_ indicators while an element is being dragged? That could work.

Thoughts, @swissspidy?

with-numbers

I wonder if it might make sense to always display the numbers instead since it can get confusing with multiple pages, e.g.:

Screenshot 2019-09-27 at 12 32 42

Not sure. @cathibosco any thoughts? Perhaps there's a better alternative.

@miina Based on the mockups above, I do think it makes sense to have the number displayed for the page sequence...
It also makes sense to have them always display (rather than to display only on drag action) based on the UX of the editor currently.
Of the two mockups ups above: I think the position of the number in this mock up is the most useful.
65762899-661fab80-e122-11e9-81b6-b74096c6723c

Note: As the user selects the page to move or work on, the bar or page indicator gets highlighted - perhaps the number could also become a darker color or bold to highlight as well.

Instructions for testing:

  • Add a few pages
  • Verify that the pages have page numbers displayed in the carousel below
  • Verify that it's possible to reorder the pages by dragging the carousel indicators (and that they are moved to the correct location).

Am unable to drag the bars along the bottom successfully - pages above aren't changing position

Am unable to drag the bars along the bottom successfully - pages above aren't changing position

Yes, there's a bug for it in #3464.

Looks like #3412 (using hooks where possible) caused this regression. _Looking into this_

Ok, looks like #3412 removed the DropZoneProvider, assuming that unintentionally and will add it back.

Was this page helpful?
0 / 5 - 0 ratings