Amazefilemanager: Adding folder to bookmarks make app crashes

[michaelsam94]

Expected behavior

adding folder to bookmark show toast the app not crash

Actual behavior

adding folder to bookmark show toast and app crashes

How to reproduce

• Launch Amaze filemanager
• Press on 3 dots to show menu of actions
• Press on Add to Bookmark

TESTING ENVIRONMENT

Operating system: ANDROID V7.0
App Version: v3.2.1

Recording Of The Bug

[michaelsam94]

the problem here try to modify ui element from background thread

this function in DataUtils class need to call callback from uithread not from background thread

[michaelsam94]

need to centralize writing to sqlDatabase in UtilsHandler to run all writes to database in background thread

[EmmanuelMess]

Please don't put an image of a piece of code in the project if you can throw the link to it in the comment. Example:

https://github.com/TeamAmaze/AmazeFileManager/blob/e7d4533c340199254280c77fd47191f4b63d25a5/app/src/main/java/com/amaze/filemanager/activities/MainActivity.java#L268-L273

Results in:

https://github.com/TeamAmaze/AmazeFileManager/blob/e7d4533c340199254280c77fd47191f4b63d25a5/app/src/main/java/com/amaze/filemanager/activities/MainActivity.java#L268-L273

[michaelsam94]

Okay @EmmanuelMess I will consider this next time.

[michaelsam94]

@EmmanuelMess I need to refactor UtilsHandler can I do this or this not important now?

[EmmanuelMess]

Refractory would be problematic as v3.3.0 is feature complete and I don't want more bugs. Bug fixes are ok though, leading to a grey area where you PR (with refractoring) will probably be pulled but could lead to bugs, which I don't want. Hence, do what you have (to reduce bugs) but carefully, please.

[michaelsam94]

@EmmanuelMess I will be careful and If I change any part I will make sure not affect other parts