Amazefilemanager: Last point in ProcessWatcherFrament has copy speed that's incoherent
It always happens that the copy speed goes up→down→up→...→absurdly up.
EmmanuelMess
All 19 comments
Not really...
There is this thing that the update interval is 1 sec throughout but at last sec... If progress completes before a second, then it's updated at that moment only instead of waiting for a whole second to update which I guess is an expected behavior.
VishalNehra
on 15 Dec 2017
Where's the waiting code?
EmmanuelMess
on 15 Dec 2017
There's no waiting code, I'm saying that we don't wait for a second to complete and post update whenever the progress actually completes. Maybe the copy speed actually was that much for you in that last second?
VishalNehra
on 15 Dec 2017
It happens always, I don't think it's my phone.
There is this thing that the update interval is 1 sec throughout but at last sec...
Where's the waiting code for the "update interval of 1 sec".
EmmanuelMess
on 15 Dec 2017
VishalNehra
on 15 Dec 2017
One day, I'll have to edit that class...
EmmanuelMess
on 15 Dec 2017
Also happens encripting, I suppose it should be fixed, it doesn't seem real:
EmmanuelMess
on 15 Dec 2017
Can't reproduce, please try to reproduce on a different device.
VishalNehra
on 15 Dec 2017
Alright, I can reproduce this issue with the changes in your PR #876
Can't reproduce on master.
VishalNehra
on 18 Dec 2017
I'll check.
EmmanuelMess
on 18 Dec 2017
Nope, on master also occurs, where did you copy the file? I did it on internal memory. Haven't really changed the way the code works in PR #876.
EmmanuelMess
on 18 Dec 2017
Yep, in internal memory. Can't reproduce on master but in your PR.
VishalNehra
on 19 Dec 2017
Haven't really changed the way the code works in PR #876.
EmmanuelMess
on 19 Dec 2017
@TranceLove could you test?
EmmanuelMess
on 24 Jan 2018
Sure, will look into it tomorrow. It's late in the night here now.
TranceLove
on 24 Jan 2018
Had been battling during the day, so I only tried copy over SFTP for a quick verification.
I think #916 also helped on fixing the problem however.
Before applying.
I suppose nobody will believe 513MB can be copied to an Android device [emulator though] at lightspeed? I think this behaviour is the same as what #916 tries to fix.
After
If #876 is also needed, you will have to fix the conflicts with #916... but before it happens, #916 needs to be accepted, which also has its own problem to fix first.
TranceLove
on 25 Jan 2018
I'm on finalising #916
VishalNehra
on 25 Jan 2018
Then #876 isn't causing this issue and can be pulled...
EmmanuelMess
on 25 Jan 2018
Cannot replicate anymore, closing.
EmmanuelMess
on 26 Apr 2018
Related issues
germanfr
·
5Comments
bowiechen
·
3Comments
Wilker-a
·
5Comments
sjl872964789
·
5Comments
TjrGithub
·
5Comments