Aks-engine: Support aks-engine add and remove agent pools

Created on 11 Jul 2019 · 11Comments · Source: Azure/aks-engine

Describe the request
I think that would be really great after the standard loadbalancer is really stable to support aks-engnie add/remove agent-pool commands.

Also aks-engine upgrade single agent pool. that would be great for testing new version of k8s first before applying it on all agent pools.

This already supported with the hosted aks.

Explain why AKS Engine needs it
Manage the agent pools with aks-engine commands.

Describe alternatives you've considered
Apply this manually with arm templates, but this will not work with the single agent-pool upgrade from example.

Additional context

enhancement help wanted

Source

mo-saeed

👍2

Most helpful comment

@pierluigilenoci take a look at #2557 :)

/assign @DavidLangworthy

CecileRobertMichon on 10 Jan 2020

❤1 👍1

All 11 comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] on 9 Sep 2019

@jackfrancis @CecileRobertMichon any plans to implement this ?, this is already in aks. wondering why not in aks-engine.

mo-saeed on 9 Sep 2019

Hi @mo-saeed at present any additional cluster lifecycle foo in aks-engine is being gathered as requirements for a re-implementation of this entire area within aks-engine. Stay tuned!

jackfrancis on 9 Sep 2019

👍2

Thanks @jackfrancis !

mo-saeed on 10 Sep 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] on 9 Nov 2019

@jackfrancis Any news on this topic?

pierluigilenoci on 11 Nov 2019

https://github.com/Azure/aks-engine/pull/2209

CecileRobertMichon on 11 Nov 2019

@CecileRobertMichon now #2209 is closed. So what? :(

pierluigilenoci on 9 Jan 2020

@pierluigilenoci #2209 was closed because it was stale, ie. we didn't close it because we don't want the change, the bot closed it because there wasn't any activity in the PR recently. I believe the author didn't have time to see it to completion but the ask is still there and the initial work he did is a very good start for anyone to pick it up and start from there. I'm going to mark this one as help wanted.

/help

Also see https://github.com/Azure/aks-engine/pull/2209#issuecomment-571288857 for a manual workaround in the meantime. That PR is just adding the CLI command to do the same thing with a nicer UX.

CecileRobertMichon on 9 Jan 2020

👍1

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

@pierluigilenoci #2209 was closed because it was stale, ie. we didn't close it because we don't want the change, the bot closed it because there wasn't any activity in the PR recently. I believe the author didn't have time to see it to completion but the ask is still there and the initial work he did is a very good start for anyone to pick it up and start from there. I'm going to mark this one as help wanted.

/help

Also see https://github.com/Azure/aks-engine/pull/2209#issuecomment-571288857 for a manual workaround in the meantime. That PR is just adding the CLI command to do the same thing with a nicer UX.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.