Addons-server: After submitting a static theme "Go to my submissions" should redirect to "My Themes" tab
STR:
- Load AMO dev and submit a static theme
- Click on Go to my Submissions button after the submission is complete
- Observe the tab displayed in Manage my submissions page
Expected result:
My Themes tab is opened with sorting option "Created" displaying the last submitted theme.
Actual result:
My Add-ons tab is displayed.
Notes:
This issue is reproducible on AMO dev with FF60(Win10).
ioanarusiczki
All 8 comments
@eviljeff Can I work on this?
yshshrm
on 21 Aug 2018
@kvaluruk sure, go ahead. But note a) it's not been marked as a good first bug (yet*?) b) you'll need to write some tests c) because of (b) you'll probably need to install addons-server locally to develop the fix. *(and because of (b) and (c) it might not be marked as a good first bug)
eviljeff
on 21 Aug 2018
@eviljeff sorry for that quick fix PR, I'd still love to work on this issue! I've never worked with testing before though. How can I get started?
If you think it'll be a bit complex, I'll look into the other issues. Thanks!
yshshrm
on 21 Aug 2018
It's up to you. It's perhaps not a super beginner issue, but I think you can just see what tests fail on the Travis test run and then change those lines. Once you've made the template change I requested if you can't work out how to change the tests I'll point the lines out.
eviljeff
on 21 Aug 2018
Hey @kvaluruk! Since you are close to closing this bug out, we are marking you as assigned to this bug. :)
@eviljeff is here to help with questions about the tests to help you get this over the finish line!
caitmuenster
on 22 Aug 2018
@eviljeff @caitmuenster Thanks for the motivation and guidance! This was my first ever OS contribution, looking forward to getting involved even more :heart: :tada:
yshshrm
on 22 Aug 2018
Nicely done, @kvaluruk! Your contribution has been added to our recognition wiki and your mozillians.org profile has been vouched.
Welcome onboard! We look forward to seeing you around the project. 馃帀
caitmuenster
on 22 Aug 2018
Verified fixed on AMO dev with FF61(Win10)
ioanarusiczki
on 24 Aug 2018
Related issues
diox
路
5Comments
hwine
路
7Comments
jvillalobos
路
7Comments
jvillalobos
路
4Comments
grahamperrin
路
5Comments
Most helpful comment
@eviljeff @caitmuenster Thanks for the motivation and guidance! This was my first ever OS contribution, looking forward to getting involved even more :heart: :tada: