Addons-server: Add-on Developer Hub logo is displayed with layout issues in some languages

[ioanarusiczki]

Prerequisites:
User is logged in

Steps to reproduce:

1. Load AMO page and click on Developer Hub
2. Click on My Add-ons
3. Change the language from en-US to Italian
4. Observe the logo

Expected result:
The Logo is correctly displayed.

Actual result:
The black text overlaps the white text.

Notes:
Reproduced on AMO dev and AMO stage with FF57(Win 10).
I reproduced this issue with Spanish, Italian, French, Polish, Portuguese, Bulgarian, Bahasa Indonesia, Romanian.

[anweshknayak]

Can I take this up ?

[muffinresearch]

@anweshknayak hi feel free to go ahead and let me know if you have any questions. Please reference this issue in your PR.

[caitmuenster]

Hey @anweshknayak, how's it going with this bug?

[caitmuenster]

@anweshknayak, we're going to open this bug up for other contributions to take since we haven't heard from you in awhile. Please do feel welcome to come back and pick up another bug!

[anweshknayak]

hey @caitmuenster sorry. I missed this. I am a bit occupied with some stuff lately. So I am not able to look into this. :smile:

[is2ei]

Hi, I'm Issei.
Could I work on this issue?

[caitmuenster]

Hey @is2ei! Go for it! Feel free to let @muffinresearch know if you have any questions. :)

[is2ei]

@muffinresearch
Is this fixed in #7298 ?

[muffinresearch]

Is this fixed in #7298 ?

@is2ei I don't understand the question. The linked issue is this bug. Did you mean to link some other issue or PR?

[is2ei]

@muffinresearch
Sorry, the link was wrong. I mean this commit refers this issue #7298 https://github.com/gponimansky/addons-server/commit/7013e50e0687b48bbd88c89fb8af867c1eca4843
The comment says "Fixed Issue #7298".

[gponimansky]

Oh @is2ei it's a workaround fix will update it. I suggested where a true fix may take place.

Refer to my older comment for reference.

[is2ei]

@gponimansky
Thanks for your comment! I confirmed the issue can be reproduced. I will work on this issue.

[is2ei]

Hi @muffinresearch
I run the app locally and I can change the language of the header.

Do I need more settings?

[muffinresearch]

@is2ei sorry for the slow reply. That should be all you need to reproduce. Just change the locale to see the header in different languages. From the OP the bug was reproducible in the Italian locale.

[caitmuenster]

Hey @is2ei, are you still interested in working on this bug?

[andreip]

@caitmuenster @muffinresearch I've got docker setup and tried to reproduce this, but the header doesn't seem to be translated on my local (see below screenshot), which is similar to what @is2ei posted anyway, notice his url is for italian, but the text is still _mostly_ in english. Notice that "Documentazione" and the one I selected in the dropdown are translated, but mostly rest is still in english. That's a bit strange, since navigating to https://addons.mozilla.org/it/developers/addons clearly shows you've got translations for a lot more words on the website.

(I've also done compose pull and docker build -t addons/addons-server . before compose up to have the latest things from master - commit 6ac143c2a2)

[EnTeQuAk]

So, from the GIF attached to the bug report the actual layout issue occurs for the pt-PT locale, and not Italian.

Maybe that helps reproducing this?

[andreip]

Thanks! I eventually figured out that the issue was I didn't have the .mo files compiled on local. I ran these to fix it:

$ docker-compose exec web ./locale/compile-mo.sh ./locale/
$ docker-compose restart web

[andreip]

@muffinresearch if you're still the one I should notify, I submitted a PR here https://github.com/mozilla/addons-server/pull/9182

[caitmuenster]

Thanks @andreip -- @muffinresearch is out on PTO for the next two weeks but @EnTeQuAk might be able to review your PR or find someone else to take a look at it soon. :)

[ioanarusiczki]

Verified fixed on AMO -dev with FF61(Win10)
Polish

Romanian

Spanish