Addons-frontend: Selecting “Add-on Type”-“Theme” won't highlight “Themes” from the menu

[madalincm]

STR:

1. Access AMO homepage: https://addons.allizom.org/en-US/firefox/.
2. Type any searchable term in the search field, located at the right side in the page header and press enter.
3. Once on the Search results page, select “Theme” from the “Add-on Type” drop down list, from the “Filter results”, located on the left side of the page.
4. Observe the “Themes” menu button from the page header.

Expected result:

“Themes” menu button should be highlighted.

Actual result:

“Themes” menu button is not highlighted.

Notes:

Reproduced in amo-dev, amo-stage, amo-prod with Fx68, Win10x64.

[Shubhamchinda]

Can I take it?

[Shubhamchinda]

Hey, in the amo/components/SectionLinks the viewContext has value "statictheme". So I think ADDON_TYPE_THEME should be replaced with ADDON_TYPE_STATIC_THEME.

Line

After replacing with ADDON_TYPE_STATIC_THEME :

Please let me know if I'm going right or if there's any other dependency to it, How about I go for it?

Thanks!

[willdurand]

@Shubhamchinda awesome finding, you're correct!

[Shubhamchinda]

@Shubhamchinda awesome finding, you're correct!

Thanks man!

[willdurand]

thanks @Shubhamchinda

[Shubhamchinda]

thanks @Shubhamchinda

Your welcome @willdurand :)

[madalincm]

Verified in amo-dev with FF68(Win10).