Addons-frontend: User profile avatar looks smaller than it's placeholder

[ioanarusiczki]

Followup for https://github.com/mozilla/addons-frontend/issues/7843

STR:

1. Sign in AMO and upload an image from edit profile page (take a look at it's placeholder displayed on view profile page).
2. Observe the uploaded image on view profile page

Expected result:
The avatar is at 64x64 pixels same size as it's placeholder.

Actual result:
The avatar is resized at 64x48 pixels.

Notes:
Reproducible with custom icons displayed on their detail pages too - FF66(Win10).

[willdurand]

@ioanarusiczki isn't it that the uploaded image has a landscape orientation?

[willdurand]

poke @ioanarusiczki

[avgupt]

@willdurand I was looking into this issue and I found the following:

1. If the uploaded image is square, it is displayed perfectly.
2. If the uploaded image is not square, the displayed image is resized according to the proportions.
   I think this is the desired behaviour or should the image be resized into a square image (thus distorting its proportions)?

[willdurand]

@avgupt I am not sure to be honest. That's why I asked a question ot @ioanarusiczki

[ioanarusiczki]

@willdurand It's been a while since I filed this issue. Brb!

[ioanarusiczki]

@willdurand The picture is in landscape and it is not square. I tested again on AMO dev with FF73(Win10).
I think it should be alright this way after all. Making it square it would make it look worse?

[avgupt]

Instead of stretching the image, we can crop it into a square image?

[ioanarusiczki]

@willdurand On the view profile - a square image is available now and looks good to me but I'm afraid this introduced a regression https://github.com/mozilla/addons-frontend/issues/9237

[ioanarusiczki]

@willdurand

This is how the image looks cropped on dev:

This is before the square crop on stage:

I think that without a warning message that the image is going to be cropped this would not be an improvement but a problem for the user. I don't know how many of them are square.

Let me know what you think.

[willdurand]

Right, that does not sound optimal.

[willdurand]

We decided to revert the patch for this issue and to mark this issue as wontfix.