Addons-frontend: Incorrect text wrapping on an add-on details card in Disco Pane

Created on 12 Feb 2019  路  7Comments  路  Source: mozilla/addons-frontend

Prerequisites:
extensions.webservice.discoverURL pref points to the -dev server in about:config

STR:

  1. Open your Firefox browser
  2. Navigate to about:addons
  3. Observe the description for any of the listed add-ons - i.e Awesome Screenshot Plus

Actual result:
Text for the description and custom heading are not correctly wrapped

Expected result:
There are no text layout issues in the add-on cards

Notes:

  • reproduced on AMO -dev with FF65, WIn10x64

image

ux assigned welcome p4 disco pane verified fixed regression

All 7 comments

ah well, I guess that's because I used word-break: break-all 馃槥

Hi, Can I please work on this?

This is fixed now on AMO -dev

image

However, it seems we are running in circles a bit, because this fix reintroduced the issue mentioned in #7521

image

@willdurand I favor keeping this fix (i.e #7582), because it addresses a more user facing issue. Having an unbroken string in disco pane is less likely to happen in prod, therefore I'd treat that problem with a lower priority, but it's your call in the end.

@willdurand I favor keeping this fix (i.e #7582), because it addresses a more user facing issue. Having an unbroken string in disco pane is less likely to happen in prod, therefore I'd treat that problem with a lower priority, but it's your call in the end.

ok that works for me

@willdurand should https://github.com/mozilla/addons-frontend/pull/7600 have fixed the long string issue?
I am still reproducing, hence the double check.

Another patch has been merged and should fix everything.

This looks fixed now:

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

atsay picture atsay  路  6Comments

ValentinaPC picture ValentinaPC  路  4Comments

SeanPrashad picture SeanPrashad  路  6Comments

AlexandraMoga picture AlexandraMoga  路  6Comments

ioanarusiczki picture ioanarusiczki  路  3Comments