Addons-frontend: Do not display 0 users for the search tools from More add-ons section

Created on 29 Jan 2019  路  12Comments  路  Source: mozilla/addons-frontend

As a followup for https://github.com/mozilla/addons-frontend/issues/7316

STR:

  1. Load AMO dev and go to a search tool's detail page that has a "More add-ons section"
  2. Observe the search tool displayed in that section

Expected result:
The "0 users " is not visible.

Actual result:
The search tool from the More add-ons section displays the "0 users".

Notes:
This issue is reproducible on all AMO servers with FF64 (Win10).

hide the users from more addons section

add-on assigned welcome p4 verified fixed bug

Most helpful comment

@ioanarusiczki Can I take this up?

Yes but please no more than one issue in parallel :)

All 12 comments

on it.

@tsl143 are you working on this? Or can I take this up? I have worked on two similar issues.

Okay please go ahead then @twisted-sres

Thanks @tsl143 .
@ioanarusiczki Can I take this up?

@ioanarusiczki Can I take this up?

Yes but please no more than one issue in parallel :)

Okay, now that you have merged my PR for that other issue, can I take this up?
I am not working on any other issue.

Yes please start working on it :)
@twisted-sres

@ioanarusiczki when I have hidden the number of users for all the search tools, why is it still being displayed on More add-ons section?

@ioanarusiczki when I have hidden the number of users for all the search tools, why is it still being displayed on More add-ons section?

@twisted-sres this is a different component.

@twisted-sres @willdurand
I checked now on AMO dev - FF65 (Win10) and the number of users in the More section is no longer displayed.

number of users not shown1

@ioanarusiczki then I guess we should close this issue?

ah yes, sorry for the confusion.

Was this page helpful?
0 / 5 - 0 ratings