Addons-frontend: Wrong button selection order when navigating with Tab inside the Rate your experience card

[AlexandraMoga]

Depends on https://github.com/mozilla/addons-frontend/issues/6579

STR:

1. Log in to AMO dev
2. Go to an add-on detail page
3. Navigate with Tab until you reach the Ratings card
4. Select a star by using your keyboard
5. Press Tab to move the focus on the Write a review button and Enter to open the review text box
6. Write a review
7. Press Tab again until the focus is switched to the Submit review button

Actual result:
The focus moves to the Cancel button before it switches to the Submit review button

Expected result:
The Submit review button is focused before the Cancel button

Notes:

• reproduced on AMO -dev with FF62, Win10x64

[biskit1]

Is it alright if I work on this?

[biskit1]

@willdurand @bobsilverberg @AlexandraMoga
I tried replicating this issue in the dev environment (yarn amo:dev, yarn amo:stage), but the rating system seems to behave differently (it appears as a popup window). Is this because I'm running a local dev environment, and if so can someone please advise on how I might be able to accurately reproduce the error and test things out?

Should I be following the instructions laid out here?

Thanks!

[kumar303]

Hi @biskit1 -- you are correct, this bug is a bit different now. I filed https://github.com/mozilla/addons-frontend/issues/6579 .

Sorry for the confusion as you tried to start developing this feature. The instructions you followed are up to date but this specific page was in a state of flux. If you update your code you should see the new review form now (not the overlay) but I would recommend looking at contrib: welcome issues instead. Those are ones that we think are ready for a contributor to work on.

I see that you have already landed some patches -- thanks so much!

[kumar303]

@biskit1 if you are most interested in review / rating features, we have a handful of issues that are ready.

[biskit1]

thanks @kumar303! I will take a look.

[kumar303]

I'm going to dupe this to https://github.com/mozilla/addons-frontend/issues/6579 because the screen changed it a bit and that bug talks about the new screens.

[kumar303]

Actually, yeah, after I got past the issue in https://github.com/mozilla/addons-frontend/issues/6579 I can see the problem with using the keyboard to access the Submit review button. I am re-opening this but I did update the description to fix the button names (which changed in some redesigning).

[AlexandraMoga]

Verified fixed on AMO -dev with FF63, Win10x64