Addons-frontend: Content change for All Reviews page

[bobsilverberg]

This is a follow-up to PR #6019.

@MeridelW Should we also change the text from "x star average" to "x Stars" on the All reviews page?

[MeridelW]

@bobsilverberg For clarity, and for users who can't see the stars (do we have alt text for the stars?), could we use this header? # out of 5 stars ?

Example: 4.5 out of 5 stars

[bobsilverberg]

Thanks @MeridelW

do we have alt text for the stars?

We do not have alt text specifically, but we do have a title for each star, as well as a title for the box that holds the stars. Each of those titles reads "Rated # out of 5".

Do you think that suffices, or do you still want to update the text under the stars to read "# out of 5 stars"?

[MeridelW]

@bobsilverberg Aha, got it.

In that case, we could go with either text: "x star average" or "x Stars." I think it is apparent enough that the user is seeing an average and a pattern for reviews on other sites is no heading at all - just a visual of the stars.

For the sake of internal consistency and simplicity, I prefer "x Stars" as the text beneath the visual.

[MeridelW]

@bobsilverberg A follow-up question: are the titles you mention visible? I don't see them in the screenshot above.

[bobsilverberg]

A follow-up question: are the titles you mention visible? I don't see them in the screenshot above.

They are not visible in the browser. They manifest as pop-up messages when you hover over any of the items. I'm not sure if they also help with a11y or not.

[MeridelW]

@bobsilverberg Ah, okay.

I am not sure if that helps with a11y or not, either. In that case, in the event someone can't see the stars, it is safer to go with this text: # Stars out of 5

[caitmuenster]

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

Mentor: @bobsilverberg

[Balaji2198]

@caitmuenster I would like to work on this issue.

[championshuttler]

Hey @Balaji2198 , its weekend everyone is offline almost , feel free to submit the PR :smile: .Let me know if you get stuck anywhere or need any help with setting up the project.

[Balaji2198]

Thanks, @championshuttler for the heads up. I set up the project successfully, and I did the necessary changes But when I run the tests yarn test tests/unit/amo/components/TestAddonSummaryCard.js.
This error occurs. Same thing happens if i run all the tests yarn test. Any idea on how to fix this?

FYI: I'm on Ubuntu 16.04

[championshuttler]

Thanks, @championshuttler for the heads up. I set up the project successfully, and I did the necessary changes But when I run the tests yarn test tests/unit/amo/components/TestAddonSummaryCard.js.
This error occurs. Same thing happens if i run all the tests yarn test. Any idea on how to fix this?

FYI: I'm on Ubuntu 16.04

Hi @Balaji2198 , thanks for working so far , could you please raise a Pull Request wih the changes you made, we will see here with Travis CI, what's going wrong. Though these errors are related to git if I understood completely.

[Balaji2198]

@championshuttler I raised a pull request #7238. All the tests are passing in Travis CI :)