Adapt_framework: adapt-contrib-trickle has issues with PLP

Created on 29 Jul 2021  路  6Comments  路  Source: adaptlearning/adapt_framework

Subject of the issue/enhancement/features

PLP can't find element from trickle buttons to check isInViewport.

trickle-broken-course.zip

bug high priority
Source
picture simondate

Most helpful comment

My bad 馃槰 I should have remembered the changes to this plugin

picture simondate on 3 Aug 2021
❤1 😄1

All 6 comments

Can I have an unminified output?

oliverfoster picture oliverfoster on 30 Jul 2021

@oliverfoster
3213-output.zip

simondate picture simondate on 30 Jul 2021

image

oliverfoster picture oliverfoster on 2 Aug 2021

image
You have a custom plp which is causing it.

Closing issue.

oliverfoster picture oliverfoster on 3 Aug 2021

My bad 馃槰 I should have remembered the changes to this plugin

simondate picture simondate on 3 Aug 2021
❤1 😄1

It should just fail silently rather than throwing an error. Make sure to check errors with sourcemapping turned on, that way they're much more informative about the origin of the bug.

oliverfoster picture oliverfoster on 3 Aug 2021
Was this page helpful?
0 / 5 - 0 ratings

Related issues

brian-learningpool picture brian-learningpool  路  4Comments
ryanlynch717 picture ryanlynch717  路  4Comments
danielstorey picture danielstorey  路  3Comments
BillGilmoreLP picture BillGilmoreLP  路  6Comments
chucklorenz picture chucklorenz  路  5Comments