Accelerated-mobile-pages: PHP Errors in latest version 0.9.97.46.1 after activation on fresh WP installation

Created on 15 Apr 2019 · 22Comments · Source: ahmedkaludi/accelerated-mobile-pages

After installing and activation latest plugin version (0.9.97.46.1) on fresh WP installation (WP 5.1.1 with debug = on) get a lot of PHP errors (previous plugin versions worked fine):


Notice: Undefined index: amp-on-off-for-all-pages in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/install/index.php on line 69

Notice: Undefined index: amp-design-selector in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/accelerated-moblie-pages.php on line 776

Notice: Undefined index: ampforwp-custom-logo-dimensions in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/options/admin-config.php on line 1220

And a lot of errors related to this first errors.

NEXT UPDATE Urgent bug

Source

dedalx

All 22 comments

Need to use ampforwp_get_setting on all places this will resolve the issue.

MohammedKaludi on 15 Apr 2019

Need to use ampforwp_get_setting on all places this will resolve the issue.

But this error in your plugin files itself (not in some theme files that use plugin), when release with fixes for this will be available? I just activated plugin on fresh WP and default theme.

dedalx on 15 Apr 2019

Yes, these warnings are from the pluign itself.

These are just the warnings (and will not effect anything interms of pluign performance) and you can disable it by turning off the debug mode from your wp-config.php file or if you save the settings once these warnings will disappear.

And we Will fix these issues in upcoming updates, might take two weeks to fix and push it live.

MohammedKaludi on 15 Apr 2019

Yes, these warnings are from the pluign itself.

These are just the warnings (and will not effect anything interms of pluign performance) and you can disable it by turning off the debug mode from your wp-config.php file or if you save the settings once these warnings will disappear.

And we Will fix these issues in upcoming updates, might take two weeks to fix and push it live.

This is very bad, because this plugin included with themes that will not pass review with this errors (themes tested by reviewers with debug mode). Do you know what previous plugin version we can use to avoid this errors, or this affect previous versions too? (but I don't get this errors before).

dedalx on 15 Apr 2019

Let me check it out and will get back to you.

MohammedKaludi on 15 Apr 2019

need to make sure this code is there in ampforwp_get_setting function

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/5e2798a5165d6b7dcd0acfa1952fbba184d9a87f#diff-260eba6333c3222e59a6aed22ac5ab37L1248

MohammedKaludi on 15 Apr 2019

Make sure to add the below code in ampforwp_get_setting function when merging this ticket.
if(empty($redux_builder_amp)){ $redux_builder_amp = (array)get_option('redux_builder_amp'); }

MARQAS on 16 Apr 2019

* Review *

[x] Kaleem
[x] Imran

pegazee on 17 Apr 2019

:+1: ready to merge

MohammedKaludi on 18 Apr 2019

When this fix will be available? (at least for manual download before official release).

dedalx on 22 Apr 2019

@dedalx,
It will be added in the v0.9.97.48 and we're planning to release this today evening or maybe tomorrow morning.

pegazee on 23 Apr 2019

Pushed in 0.9.97.48

pegazee on 25 Apr 2019

I am not sure how you test your plugin activation with Debug mode enabled on fresh WordPress installation, but you don't fixed all errors and now have much more new similar PHP notice errors on activation:

Notice: Undefined index: amp-analytics-select-option in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/features/analytics/analytics-options.php on line 6
(this errors appears few times in some loop)

Notice: Undefined index: amp-opt-color-rgba-colorscheme in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/options/admin-config.php on line 3326
Notice: Undefined index: amp-design-selector in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/options/admin-config.php on line 5941

Still get some old errors that I reported before:

Notice: Undefined index: ampforwp-homepage-on-off-support in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/features/functions.php on line 38
Notice: Undefined index: amp-frontpage-select-option in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/features/functions.php on line 41
Notice: Undefined index: ampforwp-homepage-on-off-support in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/features/functions.php on line 38
Notice: Undefined index: amp-frontpage-select-option in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/features/functions.php on line 41

And yes, I use latest version Version 0.9.97.48 from WordPress.org on fresh installation.

dedalx on 25 Apr 2019

@dedalx, We are sorry for the inconvenience.
I have noted the warnings reported by you here: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/3085. We will resolve it ASAP.
Please follow that ticket for more info.

MARQAS on 25 Apr 2019

👍1

@dedalx, We are sorry for the inconvenience.
I have noted the warnings reported by you here: #3085. We will resolve it ASAP.
Please follow that ticket for more info.

Any updates on this issues?

dedalx on 29 Apr 2019

Old issues is fixed now, but I get new error on activation...

Notice: Undefined index: amp-design-selector in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/options/admin-config.php on line 5995

dedalx on 29 Apr 2019

@dedalx, We are sorry for the inconvenience.
I have noted the warnings reported by you here: #3085. We will resolve it ASAP.
Please follow that ticket for more info.

Any updates on this issues?

3085 ticket has been fixed and pushed in last update and

Old issues is fixed now, but I get new error on activation...

Notice: Undefined index: amp-design-selector in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/options/admin-config.php on line 5995

This debug has been added #3103 and will be fixed and pushed in next update.

MohammedKaludi on 29 Apr 2019

@MohammedKaludi Thanks, when next update will be released on WordPress.org?

dedalx on 30 Apr 2019

It will be pushed in todays update

MohammedKaludi on 30 Apr 2019

@MohammedKaludi Great, thanks!

dedalx on 30 Apr 2019

👍1

I found new similar error so I post it here. It appears when your plugin is activated and you visit WooCommerce page (Shop, Single product, etc) with Debug = on:

Undefined variable: wp in /Volumes/Storage/MAMP/htdocs/wp-test/wp-content/plugins/accelerated-mobile-pages/includes/redirect.php on line 321

dedalx on 7 May 2019