Zwave2mqtt: [bug] fswatcher error when starting z2m

[chilicheech]

Version

Build/Run method

• [x] Docker
• [ ] PKG
• [ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt Docker version: 4.0.1

Describe the bug
When starting the container I get the following error:

z2m     | /usr/src/app/lib/Gateway.js:51
z2m     |         fn()
z2m     |         ^
z2m     |
z2m     | TypeError: fn is not a function
z2m     |     at FSWatcher.<anonymous> (/usr/src/app/lib/Gateway.js:51:9)
z2m     |     at FSWatcher.emit (events.js:315:20)
z2m     |     at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:135:12)

To Reproduce
Steps to reproduce the behavior:

1. Run the 4.0.1 image with no customDevices file
2. Observe the container fail with the error

Expected behavior
The container starts with no error

Additional context
This may be related to changes introduced by #670 and #675

Downgrading to 4.0.0 makes it work again.

Cheers,

[robertsLando]

@pdbogen could you check this?

[JasonSwindle]

Yep, getting the same

[39m2020-08-21T17:37:40.210Z z2m:Zwave Zwave connected, Openzwave version: 1.6.1240

2020-08-21 12:37:40.210 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_GET_VERSION: 0x01, 0x03, 0x00, 0x15, 0xe9
2020-08-21T17:37:40.270Z z2m:App Listening on port 8091
/usr/src/app/lib/Gateway.js:51
fn()



TypeError: fn is not a function
at FSWatcher.<anonymous> (/usr/src/app/lib/Gateway.js:51:9)
at FSWatcher.emit (events.js:315:20)
at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:135:12)

[robertsLando]

Sorry guys tested it too quickly, fill fix asap

[pdbogen]

Yep, I see the problem. Thanks for the report; I'll have a PR up momentarily.

[jghaanstra]

This issue is closed but the latest release does not have this fix yet. Will there be a new release that includes this fix?

[robertsLando]

@jghaanstra sorry but I'm out this weekend and I don't know if I will be able to release 4.0.2 today, maybe tomorrow or for sure on Monday I will. @chrisns if you have time feel free to make a new release :)

[jghaanstra]

@jghaanstra sorry but I'm out this weekend and I don't know if I will be able to release 4.0.2 today, maybe tomorrow or for sure on Monday I will. @chrisns if you have time feel free to make a new release :)

No problem, reverted back to 4.0.0 but was wondering if I missed something. Enjoy the weekend.

[chrisns]

I'm on leave this week. Not allowed on a computer :)

[niemyjski]

I'm still seeing this error even when building against master.

[jghaanstra]

For me 4.0.2 fixed this issue. Pulled from docker hub.

[pdbogen]

Would you mind confirming which SHA you're building? git rev-parse HEAD

Farther down in lib/Gateway.js, there are calls to watch, at lines 106, 107. What do these look like in your copy?

On August 24, 2020 2:08:05 PM UTC, Blake Niemyjski [e-mail] wrote:

I'm still seeing this error even when building against master.

z2m:App Listening on port 44920
/opt/lib/Gateway.js:51
       fn()
       ^

TypeError: fn is not a function
   at FSWatcher.<anonymous> (/opt/lib/Gateway.js:51:9)
   at FSWatcher.emit (events.js:315:20)
at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:135:12)

[robertsLando]

I think @niemyjski is hitting his docker cache it's impossible he is using latest version, that is fixed @pdbogen

[pdbogen]

Yep, I think so as well; either docker cache, or maybe forgot to git pull, or other git wackiness. I wanted to confirm & make sure it's not something else, though.

[niemyjski]

I delete and rebuild the image locally. I'll ensure it's not being cached thanks!