Zulip-desktop: Clicking on Zulip icon in macOS dock makes the window disappear

[varkor]

I just upgraded to Zulip v5.0.0 on macOS Sierra and now the window toggles between visible and invisible every time I click on its icon in the dock. Presumably this is a bug instead of a "feature", but it is very frustrating. (This was very confusing at first, when I tried switching to it by clicking on the icon, it wouldn't be there.)

[fritzhardy]

Also on MacOS Catalina 10.15.3.

[akashnimare]

I see. This was added in here. If it's not useful we'll remove this feature. More info on this here.

[varkor]

@akashnimare: this is a really confusing behaviour — I couldn't understand why Zulip was frequently disappearing. If you switch apps by clicking on the icon, half the time Zulip won't be there when you try to switch to it. It took me a while to figure out what was happening. I'm positive this is causing consternation for others too. I think this needs to be reverted and backported to a minor version soon: it's a significant reduction in UX.

[cognusion]

I've heard from 3 mac users at our site that this is confusing.

[timabbott]

I'm not familiar with the details of how this works, but we've gotten a lot of complaints about this (here and elsewhere), which makes me think we should either revert or rework this to work how users expect.

[varkor]

If you absolutely wanted to keep this behaviour in some form, it could be acceptable to toggle the visibility of Zulip if Zulip is currently the topmost window, in the current space and focused. This would make it much more obvious what was going on. However, I personally don't see why this behaviour is desirable in the first place (you can already hide applications with Command-H and clicking-to-hide is not a common macOS convention).

[virtuaris]

This behaviour is at least annoying. In daily work it simply means i always have to click the dock icon twice to get the Zulip window and that for 10k times (exaggerated of course). This is the only application which behaves that way. Just my 5ct.

[akashnimare]

@varkor this is what I'm planning -

• Remove the toggle behaviour which triggers after clicking on the dock icon
• Do not hide window on clicking dock (just show it if it's hidden)

Is that correct?

[akashnimare]

Pushed some changes -

[varkor]

@akashnimare: this looks good to me :)

[kanunnikau]

If you absolutely wanted to keep this behaviour in some form, it could be acceptable to toggle the visibility of Zulip if Zulip is currently the topmost window, in the current space _and_ focused. This would make it much more obvious what was going on. However, I personally don't see why this behaviour is desirable in the first place (you can already hide applications with Command-H and clicking-to-hide is not a common macOS convention).

I have just discovered (due to this Zulip bug) that there is Alt+Click in macOS. It does exactly the thing that was intended here - to toggle visibility of current app. Try to play with Alt+Clicking on Zulip - it will jump between showing Zulip and your previously opened app. If you had a lot of apps opened and not minimised there will be a lot of clicking, apps flashing, and then you will arrive at the desktop. Trippy :)

[akashnimare]

We have fixed this in master. Will push a new release soon which will contain the fix. Thanks, everyone!

[toph-allen]

Just came here to post this — thanks for fixing this!

[stuartbryson]

Just came here to post this as well.

If it's helpful, I was going to make reference to the Apple Human Interface guidelines as well:

As far as I can tell, the dock icon is currently configured to toggle visibility of the Zulip application. If Zulip is visible, clicking on the dock icon will hide Zulip. If Zulip is hidden, clicking on the dock icon will show it. More jarringly, if Zulip is visible by behind other windows, clicking on the app icon will first bring Zulip to the front, and then hide Zulip completely. This results in a "flash" before it gets hidden.

Apple has clear guidelines on what clicking the dock icon should do: "Activate a window when the user clicks your app’s icon in the Dock. If your app is already running with open windows, activate the front open window or the last minimized window. If your app isn’t already running or is running without any open windows, open your main window or a new document window."

[rhusar]

Thanks for the fix/behavior revert. Given this type of issue is hit many times a day (I am actually considering using zulip in a browser tab in the meantime) is there any ETA on 5.0.1 release or a pre-release at least?

[akashnimare]

@rhusar we are in the middle of pushing a new release v5.1.0. It should be up in a day :)

[rhusar]

@akashnimare Perfection! Thanks a lot.

[toph-allen]

Thanks — I’m so glad to have this working as expected again :)

On Apr 28, 2020, at 3:25 PM, Radoslav Husar [e-mail] wrote:

@akashnimare https://github.com/akashnimare Perfection! Thanks a lot.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/zulip/zulip-desktop/issues/914#issuecomment-620807405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXZGPH53AHSTMF54SFBK3DRO4UTVANCNFSM4LY63EUA.

[akashnimare]

Update - we just pushed v5.1.0 which has the fix for this issue, the app should be able to auto-update itself :)

[rhusar]

@akashnimare Just updated, dock behavior works as expected (again!).