Yo's; just noticed a few things I missed when I looked over the PR:
The following used to trigger:
Now gets the unit wrong, treats b as bytes when it should be bits (https://github.com/duckduckgo/zeroclickinfo-goodies/issues/3990) : https://duckduckgo.com/?q=1+Gb+in+MB&t=vivaldi&ia=answer
Accuracy regression: https://duckduckgo.com/?q=100+megabytes+in+bytes&t=vivaldi&ia=answer (https://github.com/duckduckgo/zeroclickinfo-goodies/issues/2951), probably irrelevent for megabytes, but important for mebibytes
@pjhampton
Instant Answer Page: https://duck.co/ia/view/conversions
Hey @duckduckgo/duckduckhack-contributors
Would anybody like to support these over the weekend?
I have a dump of conversions that had to be dropped in the v2 initially - but can now be added back in.
Now that I've thought about it a bit, maybe we should break this down into many smaller tasks. We're not just regressing here but across all the categories. Further, these are just some examples - we want to be as comprehensive as possible like Bing.
Let's start with closing this and creating an issue to improve Digital Conversions by adding anything that's missing. What do you guys think?
@pjhampton I've already started working on adding missing digital conversions.
Ahh, nice @Lord-Lavios. Thanks! I will create an issue later for you and assign it to you so we can keep track of this stuff.
Maybe this is an excuse to leverage Github Projects.
Closing. See
Most helpful comment
Now that I've thought about it a bit, maybe we should break this down into many smaller tasks. We're not just regressing here but across all the categories. Further, these are just some examples - we want to be as comprehensive as possible like Bing.
Let's start with closing this and creating an issue to improve Digital Conversions by adding anything that's missing. What do you guys think?