Zeroclickinfo-goodies: Timer: Improve triggering

[pjhampton]

Problem

Based on user feedback and unanswered query data, This IA isn't triggering enough. @moollaza just merged a PR that ported this IA from a Spice to a Goodie.

Triggering 👍

Not triggering 👎

Solution

1. Add one, two, or three tests! 😉
2. Add the trigger words mins, minutes

People to notify

@pjhampton

Get Started

• [ ] 1) Claim this issue by commenting below
• [ ] 2) Review our Contributing Guide
• [ ] 3) Set up your development environment, and fork this repository
• [ ] 4) Create a Pull Request

Resources

• Join DuckDuckHack Slack to ask questions
• Join the DuckDuckHack Forum to discuss project planning and Instant Answer metrics
• Read the DuckDuckHack Documentation for technical help

Instant Answer Page: https://duck.co/ia/view/timer

[forcemagic]

Is anyone working on this? I would like to, if it's possible. (I'm new btw, I'm still reading the contrib guide 😝)

[manrajgrover]

@TheSpeedyBlur Great! Sure, go ahead with this. If you face any issue, feel free to ping on Slack.

[forcemagic]

Okay, I'm sorry, I was too dumb to look at this issue in detail, and I would like to cancel my application for this issue. I'm new to the programming language (perl) and this task is too complex for me at the first try. (I should probably should look up some JS issues, cause I'm better at that) I've been sitting on it for two hours, and again, I'm sorry for dropping this, but I'm afraid I would only be able to accomplish progress if I would rewrite the whole Timer script. 😞

[BillyBarbaro]

@TheSpeedyBlur I know perl can be a bit intimidating (I'm relatively new to it myself), but I don't think this would be too hard with a bit of help. I'd be willing to point you in the right direction if you still want to take the issue. Ping me on Slack (my username there is the same as my Github) and let me know. We could figure out this one together.

[forcemagic]

@BillyBarbaro I'd be happy to do this actually and if you're willing to help me I'd be glad. I will ping you on slack when I'm available.

[pjhampton]

Thanks very much @TheSpeedyBlur and @BillyBarbaro!! I noticed you're not part of the DDG org on Github @TheSpeedyBlur, so I have only assigned @BillyBarbaro for the time being. 💙 💛 💜 ❤️

[forcemagic]

@pjhampton Should we trigger on hours / hrs, seconds / secs as well?

Also, what should I do about this test?
https://github.com/TheSpeedyBlur/zeroclickinfo-goodies/blob/c35ed3e315798cf5c25aec0fa38653d180dce3df/t/Timer.t#L103

It keeps failing every time, but me and @BillyBarbaro think that it could match. Can I remove it?