Zeroclickinfo-goodies: ColorCodes: Triggers on any query ending in "color <name>"

[moollaza]

Description

This IA is triggering for any query that ends in color <name> causing some irrelevant results.

e.g. https://duckduckgo.com/?q=symbolism+of+the+color+red&ia=answer

We need to verify that the query doesn't contain other words when the trigger is color

People to notify

/cc @mintsoft

Get Started

• [ ] 1) Claim this issue by commenting below
• [ ] 2) Review our Contributing Guide
• [ ] 3) Set up your development environment, and fork this repository
• [ ] 4) Create a Pull Request

Resources

• Join DuckDuckHack Slack to ask questions
• Join the DuckDuckHack Forum to discuss project planning and Instant Answer metrics
• Read the DuckDuckHack Documentation for technical help

---

IA Page: http://duck.co/ia/view/color_codes
Maintainer: @Mailkov

[Mailkov]

@moollaza Ok, I'm working to solve it

[moollaza]

Here's a visualization of the regex:

_source: https://www.debuggex.com/r/nAmQuV7VMZBpqOKF_

You can see that it's possible to have any string before "color red" because of the (.*?) in the regex...

[Mailkov]

@moollaza In this moment IA ColorCodes is supporting the queries "rgb color code for red" and "red color code for html" etc.
So I'm not sure I will change the regex ...

[gaulrobe]

Maybe we need to be tighter with the regex and enforce "color code" being in the query, code not being optional?

[moollaza]

@Mailkov I think we should break apart that big regex so it's easier to understand and then replace the (.*?) with words we actually expect to see.

Or maybe as a heuristic if the string doesn't contain "color code", but contains a named colour and other words, we should bail out?

@gaulrobe I'm not sure we want to be so strict as to require "color code" just yet. The IA is just a little too flexible with it's triggering right now.

[gaulrobe]

@moollaza it might help to require it in cases where "color" is in the query, since that is gonna be very ambiguous. "color code" at least is explicit in what is being asked. But either way, maybe too early to go that far. :smile:

[moollaza]

@gaulrobe ah sorry I misunderstood you!

It looks like there are a few common search forms that just contain color though...

An alternative approach is to remove words and phrases we expect to be in the query and if the result is a valid colour name or code then we could trigger.

Ultimately I think we need to break up the logic we use to evaluate the query so it's easier to reason about, and then add more tests!

[moollaza]

BTW I just noticed that "#E0E0E0 color" and "#E0E0E0 css color" don't trigger this Instant Answer -- they definitely should!

[mintsoft]

@moollaza good catch

@Mailkov Have you got a fork in progress somewhere? I don't mind picking this up if you don't have time

[GuiltyDolphin]

@mintsoft If you do, some of the test queries from #3346 might be useful to ensure it isn't over-triggering.

[moollaza]

Ping! I'm just checking in to see if anyone is still interested in finishing this one up?

[abijithka]

color: "your color";
or
backgroundbg color: " your color";