Zero-to-jupyterhub-k8s: Fix branch builds for this repo
Currently, if you push to a branch in this repo, Travis fails.
We should fix this!
yuvipanda
All 7 comments
@yuvipanda Do you think the latest addition of chartpress and the changes to .travis.yml fix this?
willingc
on 27 Feb 2018
We currently end up with two builds on travis running, this is not the correct behavior i figure.
consideRatio
on 4 Sep 2018
This is an example of an troublesome behavior, where we get two builds, one because we get a PR, and one because we added a branch.
Actionplan:
- Ensure we only do one build in this case. For an example of this issue see the build for #877
consideRatio
on 4 Sep 2018
Why not recommend against having private branches in this repository? We operate via PRs for all change so people have their own fork already and can do what they like there.
My preference for this is part "keeping the master repository tidy" and "only special people can make branches here and I don't like having special people".
betatim
on 12 Sep 2018
@betatim absolutely agree :)
yuvipanda
on 12 Sep 2018
-> close this issue? Or is there a GitHub setting we can/should use to enforce this?
betatim
on 14 Sep 2018
I don't think that GitHub offers a straightforward way to prevent new branch creation. I'm going to close.
willingc
on 14 Sep 2018
Related issues
tylere
路
4Comments
consideRatio
路
3Comments
consideRatio
路
3Comments
jgerardsimcock
路
4Comments
consideRatio
路
3Comments
Most helpful comment
Why not recommend against having private branches in this repository? We operate via PRs for all change so people have their own fork already and can do what they like there.
My preference for this is part "keeping the master repository tidy" and "only special people can make branches here and I don't like having special people".