Zero-to-jupyterhub-k8s: Investigate recent errors and failures in Travis test builds

[willingc]

Recent Travis builds have been throwing errors or failing since about #327. The passing PRs since then do not appear to have run the build fully.

Perhaps #365 related??? or build.py changes.

[yuvipanda]

I'm convinced it's a race condition somewhere, it's hard to investigate because the same script passes on my local machine :'(

[willingc]

@yuvipanda Does this line look correct to you in .travis.yml ?

- . ci/minikube.env

[yuvipanda]

yup, it does!

I suspect the problem might be fixed by https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/367, let's see!

[willingc]

Why isn't that line . ./ci/minikube.env or source ./ci/minikube.env?

[yuvipanda]

Not sure why @minrk picked the particular style, I think all three variants would be equivalent at that point.

[willingc]

Mmm... I don't think @minrk wrote those lines ;-)

[yuvipanda]

Ah, it's @manics - apologies for misattributing :)

[yuvipanda]

I've actual error messages now (see https://travis-ci.org/jupyterhub/zero-to-jupyterhub-k8s/builds/320458819)!

Warning  Failed                 11s               kubelet, travis-job-f9b24008-9030-400d-bec9-cf2c1b1a5746  Failed to pull image "jupyterhub/k8s-hub:8a3d6f2": rpc error: code = Unknown desc = Error response from daemon: manifest for jupyterhub/k8s-hub:8a3d6f2 not found

seemst o be the culprit. Investigating more

[yuvipanda]

https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/350 was the last PR that was successfully merged, and I think that's what broke all succeeding PRs. It looks like the hub image wasn't pushed properly from the deploy step, so all future builds keep looking for a hub image they can't find.

[yuvipanda]

I've fixed it now! I think #350 fixed our deploy process, but the merge of #314 happened when it was broken, causing the image pushes to not happen.

So for this case, I could fix it by making sure the image that these PRs are looking for is present. I did so by:

git checkout 8a3d6f2
./build.py --push

This has made all the PRs work!

[yuvipanda]

365 is still failing, but I'd like to get https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/367 merged so we can debug it more easily.

[willingc]

@yuvipanda Just reviewed #367 if you wish to merge.

[yuvipanda]

Thank you, @willingc! I rebased https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/365 and it is passing now! Yay we fixed the build! <3

[yuvipanda]

I'm closing this now since our builds are good to go :)