Zephyr: DISCUSS: usb_device.c: If condition judgment

Created on 4 May 2018  路  3Comments  路  Source: zephyrproject-rtos/zephyr

some if condition in usb_handle_control_transfer is very hard to understand, can we rewrite it?
such as:

if (!(setup->wLength == 0) &&
    !(REQTYPE_GET_DIR(setup->bmRequestType) ==
    REQTYPE_DIR_TO_HOST)) {
            return;
}

convent to:

if ((setup->wLength > 0) && 
    (REQTYPE_GET_DIR(setup->bmRequestType) ==
    REQTYPE_DIR_TO_DEVICE)) {
        return ;
}
USB question
Source
picture qianfan-Zhao

Most helpful comment

Maybe have it like

if (setup->wLength && REQTYPE_GET_DIR(setup->bmRequestType) == REQTYPE_DIR_TO_DEVICE) {
        return ;
}
picture finikorg on 4 May 2018
👍2

All 3 comments

@jfischer-phytec-iot @ydamigos what's you idea?

qianfan-Zhao picture qianfan-Zhao on 4 May 2018

Maybe have it like

if (setup->wLength && REQTYPE_GET_DIR(setup->bmRequestType) == REQTYPE_DIR_TO_DEVICE) {
        return ;
}
finikorg picture finikorg on 4 May 2018
👍2

ok i will make a pr to rewrite some if conditions

qianfan-Zhao picture qianfan-Zhao on 5 May 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mike-scott picture mike-scott  路  4Comments
pabigot picture pabigot  路  4Comments
KwonTae-young picture KwonTae-young  路  5Comments
snej picture snej  路  5Comments
Nukersson picture Nukersson  路  5Comments