Yup: Conditional strip

[andrepcg]

Is there any way to conditionally strip a field depending on the value of a field?

For example: strip the field after casting if a string is empty ("")

[jquense]

yup.string().when('someFIeld', { is: '', then: s => s.strip() })

[andrepcg]

@jquense
Can't test this right now, but will it work with the same field? For example, I want to strip the password field if the same field is empty string (not based on another field)

Thanks for your input!

[jquense]

it should yeah

[andrepcg]

Just tried on Codesandbox and got the following error:

Cyclic dependency: "password"
https://zkrk5yldz.codesandbox.io/node_modules/toposort/index.js:29:13
https://zkrk5yldz.codesandbox.io/node_modules/toposort/index.js:43:9
Function.toposort [as array]
https://zkrk5yldz.codesandbox.io/node_modules/toposort/index.js:22:22
sortFields
https://zkrk5yldz.codesandbox.io/node_modules/yup/lib/util/sortFields.js:50:30
ObjectSchema.shape
https://zkrk5yldz.codesandbox.io/node_modules/yup/lib/object.js:252:44

My schema is defined as:

Yup.object().shape({
  email: Yup.string()
    .email('Invalid email address')
    .required('Email is required!'),
  password: Yup.string()
    .when('password', { is: '', then: s => s.strip() })
})

[jquense]

ah ok, try something like this then:

password: yup.lazy(value => value === '' ? yup.string().strip() : yup.string())

[sabarasaba]

How would this work alongside a oneOf?

    password: yup.string(),
    passwordConfirm: yup
      .string()
      .oneOf([yup.ref('password')], 'passwords do not match')

Basically I want to validate that password is equals to passwordConfirm, and I want to strip passwordConfirm in the final output object.

[jquense]

Use when() in that case since the reference is another field you won't get the cyclical error

[sabarasaba]

Uhm I tried it but it does complain about a cyclical error:

    passwordConfirm: yup
      .string()
      .oneOf([yup.ref('password')], 'passwords do not match')
      .when('passwordConfirm', { is: true, then: s => s.strip() })

I tried going through yup tests but couldnt find anything related :thinking:

[jquense]

ok I think i see what you are trying to do, you want to strip the passwordConfirm if it matches the other password field? There isn't really a way to do that because stripping happens _before_ validating, so the field would be gone by the time you checked. You've also got the api wrong for when its when('theOtherField', { is: someSpecificValue: then: newSchema })

[sabarasaba]

ohh makes sense, thats why i couldnt even find a test for this use case. Thanks for helping :)

[mchaledg19]

Hello guy anyone can help me with this. I was trying to validate my field if the use type something on the current password filled the newpass and confirmpass will show an error "Required" I am always getting this error "Error: Cyclic dependency, node was:"confirmPassword"".

Thank you in advance :)

 currentPassword: Yup.string().when(['newPassword', 'confirmPassword'], {
  is: (newPassword, confirmPassword) => newPassword && confirmPassword,
  then: Yup.string().required('Required')
}),

newPassword: Yup.string()
  .when('currentPassword', {
    is: currentP => currentP,
    then: Yup.string().required('Required')
  })
  .oneOf([Yup.ref('confirmPassword'), null], props.t('error:not_match'))
  .matches(/[a-zA-Z]/, 'Password must contain at least one letter.')
  .matches(/[0-9]/, 'Password must contain at least one numeral.')
  .matches(/^[a-zA-Z0-9]*$/, 'Password must contain only alphanumeric')
  .min(8, 'Password must contain 8 characters.'),

confirmPassword: Yup.string()
  .oneOf([Yup.ref('newPassword'), null], props.t('error:not_match'))
  .when('currentPassword', {
    is: currentP => currentP,
    then: Yup.string().required('Required')
  })

[jquense]

There are a few issues that cover cyclical errors and how to fix them, please check those 👍

[mchaledg19]

Help pls