Yugabyte-db: Ignore undefined Gflags

Created on 1 Feb 2019  路  2Comments  路  Source: yugabyte/yugabyte-db

Currently, passing in undefined gflags will cause problems when creating clusters. An --undefok flag should be set to ignore them.

good first issue help wanted kinenhancement
Source
picture WesleyW

Most helpful comment

Hi @WesleyW,
gflags has --undefok flag for suppressing the errors. Since we are falling back to the google::HandleCommandLineHelpFlags() [flags.cc], using undefok should work without any change required.

picture swayamraina on 21 May 2019
👍4

All 2 comments

Hi @WesleyW,
gflags has --undefok flag for suppressing the errors. Since we are falling back to the google::HandleCommandLineHelpFlags() [flags.cc], using undefok should work without any change required.

swayamraina picture swayamraina on 21 May 2019
👍4

Hey @swayamraina, you're right about the undefok flag. I believe the original intent was to automatically ignore gflags that are incorrect without having to pass in an additional gflag. This can obviously lead to undesirable outcomes, so I'm going to close this issue.

WesleyW picture WesleyW on 3 Jun 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rhzs picture rhzs  路  5Comments
kevbaker picture kevbaker  路  3Comments
bmatican picture bmatican  路  3Comments
robertpang picture robertpang  路  3Comments
rahuldesirazu picture rahuldesirazu  路  3Comments