Yii2: Fix github actions pipeline, add old PHP versions

Created on 17 Feb 2020  路  11Comments  路  Source: yiisoft/yii2

  1. Pipeline is currently giving errors :(
  2. Older versions could be added https://github.com/shivammathur/setup-php/issues/169#event-3041922754
  3. v2 enhancements could be used: https://github.com/shivammathur/setup-php/pull/177

All 11 comments

@simialbi would you please take a look at these?

I'm on it

This is not action related any more I think:

https://github.com/simialbi/yii2/runs/450807602?check_suite_focus=true

1) yiiunit\framework\i18n\FormatterDateTest::testIntlAsDatetime
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'2020-02-17T15:15:32+00:00'
+'2020-02-17T15:15:32'

/home/runner/work/yii2/yii2/tests/framework/i18n/FormatterDateTest.php:210
/home/runner/work/yii2/yii2/tests/framework/i18n/FormatterDateTest.php:169
/home/runner/work/yii2/yii2/vendor/phpunit/phpunit/phpunit:52

@simialbi yes. 5.6 seems to be action-related though...

The only thing left is https://github.com/yiisoft/yii2/runs/451440448#step:15:134. That's PHP 5.4 and intl/ICU related.

And 5.5 is missing. I will make a new pr today bringing it back (if it works now)

@simialbi thanks! I think we need to wait till it's fixed. 20 minutes is too much...

I agree, way too much

I've excluded 5.4 from that intl-dependent test so 5.4 is good now.

We're green 鉁旓笍 . Thank you for helping with it.

Was this page helpful?
0 / 5 - 0 ratings