Yii2: UniqueValidator breaking for non-SQL ActiveRecord

[cebe]

See https://github.com/yiisoft/yii2-mongodb/issues/180

[cebe]

This line was compatible with the interfaces before, but now requires a specific implementation:

https://github.com/yiisoft/yii2/blob/72a690216a7165be1402271db353199044218d7f/framework/validators/UniqueValidator.php#L163

cc @developeruz

We should add an instanceof check there.

[klimov-paul]

ActiveQueryInterface::asArray() should be used at that line instead of createCommand() usage.

[cebe]

select() is also not provided by some implementations such as redis.

[samdark]

@klimov-paul asArray() does not prevent afterFind(). See https://github.com/yiisoft/yii2/issues/13453

[cebe]

@samdark afterFind() is not called on an array...

[samdark]

Right.

[klimov-paul]

select() can be avoided at all

[cebe]

it was added for optimization.

[klimov-paul]

I have noticed

[klimov-paul]

Still, either it should belong QueryInterface or removed from validator.

[cebe]

check for $query instanceof \yii\db\ActiveQuery can be done. I am working on a solution.

[developeruz]

$query always instanceof ActiveQuery or not?

[samdark]

@developeruz nope https://github.com/yiisoft/yii2-mongodb/blob/master/ActiveQuery.php

That's active query but not DB active query.

[cebe]

@developeruz no, it can be an instance of mongodb, elasticsearch or redis query. the only thing they have in common is ActiveQueryInterface.

[samdark]

The fix looks good to me.

[cebe]

It is good but it is not enough. I am working on tests for redis and elasticsearch.

[cebe]

@developeruz I have included your fix in #13487. Thank you!